Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/miekg/dns: resolve flaky test in TestExchange* #3045

Merged
merged 4 commits into from
Dec 19, 2024
Merged

contrib/miekg/dns: resolve flaky test in TestExchange* #3045

merged 4 commits into from
Dec 19, 2024

Conversation

hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Dec 17, 2024 •
edited
Loading

What does this PR do?

Addresses a flaky test in TestExchange*. The issue is likely caused by a known issue in MacOS.

Motivation

Reduce flakiness in the tracer.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Dec 17, 2024
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 17, 2024 •
edited
Loading

Datadog Report

Branch report: hannahkm/fix-testexchange
Commit report: c59893b
Test service: dd-trace-go

✅ 0 Failed, 5112 Passed, 70 Skipped, 2m 35.82s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-12-19 15:32:09

Comparing candidate commit 277e527 in PR branch hannahkm/fix-testexchange with baseline commit cd21985 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@hannahkm hannahkm marked this pull request as ready for review December 19, 2024 15:01
@hannahkm hannahkm requested review from a team as code owners December 19, 2024 15:01
@hannahkm hannahkm enabled auto-merge (squash) December 19, 2024 16:01
@hannahkm hannahkm merged commit 144d592 into main Dec 19, 2024
158 of 160 checks passed
@hannahkm hannahkm deleted the hannahkm/fix-testexchange branch December 19, 2024 16:11
hannahkm added a commit that referenced this pull request Dec 19, 2024
@hannahkm
contrib/miekg/dns: resolve flaky test in TestExchange* (#3045)
d1e90d7
e-n-0 pushed a commit that referenced this pull request Dec 23, 2024
@hannahkm @e-n-0
contrib/miekg/dns: resolve flaky test in TestExchange* (#3045)
1fef794
e-n-0 added a commit that referenced this pull request Dec 23, 2024
@e-n-0
Applied comments (ipenv, signals, gracefull shutdown)
206b21a 
Applied comments

appsec: stop storing span tags, directly call span.SetTag (#3044)

Signed-off-by: Eliott Bouhana <[email protected]>

ddtrace/tracer: Tracing as transport-only mode (APPSEC_STANDALONE) (#3033)

Signed-off-by: Eliott Bouhana <[email protected]>

fix: improving test logic for TestStreamSendsErrorCode to avoid flakiness (#3049)

vuln: upgrade golang.org/x/{crypto,net} to non-vulnerable versions (#3050)

contrib/miekg/dns: resolve flaky test in TestExchange* (#3045)

ddtrace/tracer: report datadog.tracer.api.errors health metric (#3024)

build(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1 (#3001)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Argüello <[email protected]>

ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health metric (#3019)

ddtrace/tracer: Tracing as transport-only mode (APPSEC_STANDALONE) (#3033)

Signed-off-by: Eliott Bouhana <[email protected]>

fix: improving test logic for TestStreamSendsErrorCode to avoid flakiness (#3049)

vuln: upgrade golang.org/x/{crypto,net} to non-vulnerable versions (#3050)

contrib/miekg/dns: resolve flaky test in TestExchange* (#3045)

ddtrace/tracer: report datadog.tracer.api.errors health metric (#3024)

build(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1 (#3001)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Argüello <[email protected]>

ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health metric (#3019)
e-n-0 added a commit that referenced this pull request Dec 23, 2024
@e-n-0
Applied comments (ipenv, signals, gracefull shutdown)
d6dda03 
Applied comments

appsec: stop storing span tags, directly call span.SetTag (#3044)

Signed-off-by: Eliott Bouhana <[email protected]>

ddtrace/tracer: Tracing as transport-only mode (APPSEC_STANDALONE) (#3033)

Signed-off-by: Eliott Bouhana <[email protected]>

fix: improving test logic for TestStreamSendsErrorCode to avoid flakiness (#3049)

vuln: upgrade golang.org/x/{crypto,net} to non-vulnerable versions (#3050)

contrib/miekg/dns: resolve flaky test in TestExchange* (#3045)

ddtrace/tracer: report datadog.tracer.api.errors health metric (#3024)

build(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1 (#3001)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Argüello <[email protected]>

ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health metric (#3019)

ddtrace/tracer: Tracing as transport-only mode (APPSEC_STANDALONE) (#3033)

Signed-off-by: Eliott Bouhana <[email protected]>

fix: improving test logic for TestStreamSendsErrorCode to avoid flakiness (#3049)

vuln: upgrade golang.org/x/{crypto,net} to non-vulnerable versions (#3050)

contrib/miekg/dns: resolve flaky test in TestExchange* (#3045)

ddtrace/tracer: report datadog.tracer.api.errors health metric (#3024)

build(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1 (#3001)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Argüello <[email protected]>

ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health metric (#3019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darccio darccio darccio approved these changes

Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahkm @darccio