Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(tooling) [devcontainer] Use gci lint + install tools #1691

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

tbavelier
Copy link
Member

What does this PR do?

  • Adds make install-tools as post start + defaults linter to the one used in CI

Motivation

#1671 enforces GCI, so let's ensure we use the right linter

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.49%. Comparing base (6231a15) to head (72d35d6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1691   +/-   ##
=======================================
  Coverage   49.49%   49.49%           
=======================================
  Files         218      218           
  Lines       21244    21244           
=======================================
  Hits        10515    10515           
  Misses      10182    10182           
  Partials      547      547           
Flag Coverage Δ
unittests 49.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6231a15...72d35d6. Read the comment docs.

@tbavelier tbavelier merged commit 53c0d8c into main Feb 13, 2025
23 checks passed
@tbavelier tbavelier deleted the tbavelier/devcontainer-lint-settings branch February 13, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants