-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share common types between Autoscaler versions #1663
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1663 +/- ##
==========================================
+ Coverage 49.49% 51.09% +1.59%
==========================================
Files 218 218
Lines 21244 22667 +1423
==========================================
+ Hits 10515 11582 +1067
- Misses 10182 10480 +298
- Partials 547 605 +58
Flags with carried forward coverage won't be shown. Click here to find out more. see 77 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
1f18c4b
to
bcee78a
Compare
ceeeba6
to
1c6451e
Compare
1c6451e
to
380fff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit on possibly defining solely uint64pointer while relying on other existing utils
Co-authored-by: Celene <[email protected]>
What does this PR do?
Share common types between Autoscaler versions to avoid useless conversions.
Motivation
Additional Notes
Minimum Agent Versions
Describe your test plan
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label