Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.61.x] Bump go-git to latest version #32738

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Jan 7, 2025

What does this PR do?

Backport #32719 to 7.61

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz added the qa/no-code-change No code change in Agent code requiring validation label Jan 7, 2025
@chouetz chouetz requested review from a team as code owners January 7, 2025 16:08
@github-actions github-actions bot added the medium review PR review might take time label Jan 7, 2025
@spencergilbert
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-07 16:16:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-07 18:34:46 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@spencergilbert
Copy link
Contributor

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jan 7, 2025

Devflow running: /remove

View all feedbacks in Devflow UI.


2025-01-07 18:34:45 UTC ℹ️ Devflow: /remove

@spencergilbert
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-07 18:46:32 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-07 18:48:37 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@spencergilbert
Copy link
Contributor

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jan 7, 2025

Devflow running: /remove

View all feedbacks in Devflow UI.


2025-01-07 18:48:36 UTC ℹ️ Devflow: /remove

@spencergilbert
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-07 18:50:48 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-07 20:16:59 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e1e317aa-6c41-4b8d-b86a-f462f3ff289e

Baseline: 7e06fb4
Comparison: 9d7d7e5
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization -7.99 [-11.76, -4.21] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.78 [+1.05, +2.51] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.14 [+1.05, +1.22] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.39 [-0.08, +0.85] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.30 [-0.47, +1.07] 1 Logs
quality_gate_idle memory utilization +0.28 [+0.23, +0.33] 1 Logs bounds checks dashboard
pycheck_lots_of_tags % cpu utilization +0.09 [-3.31, +3.50] 1 Logs
quality_gate_idle_all_features memory utilization +0.04 [-0.06, +0.15] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.00 [-0.78, +0.78] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.85, +0.83] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.65, +0.61] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.13, +0.08] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.06 [-0.80, +0.68] 1 Logs
otel_to_otel_logs ingress throughput -0.28 [-0.96, +0.40] 1 Logs
file_tree memory utilization -0.46 [-0.61, -0.31] 1 Logs
quality_gate_logs % cpu utilization -0.85 [-3.82, +2.12] 1 Logs
basic_py_check % cpu utilization -7.99 [-11.76, -4.21] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@spencergilbert spencergilbert merged commit 166e6f6 into 7.61.x Jan 7, 2025
358 of 380 checks passed
@spencergilbert spencergilbert deleted the nschweitzer/backport_32719_61 branch January 7, 2025 20:16
@github-actions github-actions bot added this to the 7.61.0 milestone Jan 7, 2025
@michaelcretzman
Copy link
Contributor

@spencergilbert looks like this was merged before Documentation was able to review.

Do you still want Documentation to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants