Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-6567] Generate new web vitals attribution fields #3251

Open
wants to merge 2 commits into
base: v6
Choose a base branch
from

Conversation

sethfowler-datadog
Copy link

Motivation

This PR adds code to generate the new web vitals attribution fields that were added to the event format in this PR.

For now, the old web vitals fields remain. To remove them safely without breaking backwards compatibility, we need backend changes, so we'll hold off until those are done.

Changes

  • The rum-events-format submodule has been updated to include the new fields.
  • The new fields have been added to the appropriate type definitions.
  • The code to populate the new fields has been added to viewCollection.ts.
  • The tests have been updated appropriately.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@sethfowler-datadog sethfowler-datadog requested a review from a team as a code owner January 6, 2025 15:47
@sethfowler-datadog sethfowler-datadog force-pushed the seth.fowler/new-web-vitals-attribution-fields branch from cefc56e to 3954e43 Compare January 6, 2025 15:50
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (356436d) to head (9102f3f).
Report is 6 commits behind head on v6.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #3251      +/-   ##
==========================================
- Coverage   93.50%   93.49%   -0.01%     
==========================================
  Files         288      288              
  Lines        7590     7597       +7     
  Branches     1726     1731       +5     
==========================================
+ Hits         7097     7103       +6     
- Misses        493      494       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethfowler-datadog
Copy link
Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Jan 8, 2025

Devflow running: /to-staging

View all feedbacks in Devflow UI.


2025-01-08 14:19:04 UTC ℹ️ Branch Integration: starting soon, median merge time is 11m40s

Commit 9102f3f453 will soon be integrated into staging-02.


2025-01-08 14:19:27 UTC 🚨 Branch Integration: This merge request has conflicts

We couldn't automatically merge the commit 9102f3f453 into staging-02!

You can use this resolution PR: #3267 to fix the conflicts.

dd-devflow bot added a commit that referenced this pull request Jan 8, 2025
@sethfowler-datadog
Copy link
Author

/to-staging -c

@dd-devflow
Copy link

dd-devflow bot commented Jan 8, 2025

Devflow running: /to-staging -c

View all feedbacks in Devflow UI.


2025-01-08 15:43:11 UTCDevflow: /to-staging -c

Cannot cancel integration of 9102f3f453 into staging-02:

This merge request was already processed and can't be unqueued anymore.

To get help about command usage, write /to-staging --help

If you need support, contact us on Slack #devflow with those details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants