Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ [POC] Add survey collection #3195

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Dec 3, 2024

Motivation

VOC (a.k.a voice of customer)
Implement a survey tool for user feedback

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner December 3, 2024 16:50
@amortemousque amortemousque changed the title [HAckAdd survey collection [POC] Add survey collection Dec 3, 2024
@amortemousque amortemousque marked this pull request as draft December 3, 2024 16:51
Copy link

cit-pr-commenter bot commented Dec 3, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 162.12 KiB 164.38 KiB 2.25 KiB +1.39%
Logs 55.84 KiB 55.84 KiB 0 B 0.00%
Rum Slim 110.96 KiB 113.22 KiB 2.25 KiB +2.03%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 -0.000
addaction 0.041 0.041 0.001
addtiming 0.001 0.001 -0.000
adderror 0.053 0.034 -0.019
startstopsessionreplayrecording 1.169 1.020 -0.149
startview 1.547 0.333 -1.214
logmessage 0.026 0.022 -0.005
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 8.34 KiB 7.78 KiB -576 B
addaction 40.52 KiB 38.80 KiB -1763 B
addtiming 7.18 KiB 6.21 KiB -996 B
adderror 44.21 KiB 42.86 KiB -1387 B
startstopsessionreplayrecording 5.77 KiB 6.86 KiB 1.09 KiB
startview 421.60 KiB 425.81 KiB 4.21 KiB
logmessage 41.79 KiB 42.91 KiB 1.12 KiB

🔗 RealWorld

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 23.25581% with 66 lines in your changes missing coverage. Please review.

Project coverage is 92.68%. Comparing base (4ffe796) to head (c79bdf1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/rum-core/src/domain/voc/survey.ts 12.12% 58 Missing ⚠️
packages/rum-core/src/domain/voc/trigger.ts 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3195      +/-   ##
==========================================
- Coverage   93.47%   92.68%   -0.79%     
==========================================
  Files         280      282       +2     
  Lines        7703     7789      +86     
  Branches     1727     1740      +13     
==========================================
+ Hits         7200     7219      +19     
- Misses        503      570      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amortemousque amortemousque changed the title [POC] Add survey collection ⚗️ [POC] Add survey collection Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants