-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIE-204 Narrow Ajax Usage pt22 #5229
Conversation
32f6446
to
af2257e
Compare
- narrowed Ajax() usage within src/data-catalog area to call Ajax().SubAreaX directly. - this is the last usage outside of src/libs/ajax, which will be cleaned up next.
- minor import cleanup
af2257e
to
eb590b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK. I think you could also remove the Catalog
member from Ajax
with this PR.
@@ -4,7 +4,7 @@ import { div, h } from 'react-hyperscript-helpers'; | |||
import { ButtonPrimary, spinnerOverlay } from 'src/components/common'; | |||
import FooterWrapper from 'src/components/FooterWrapper'; | |||
import { TopBar } from 'src/components/TopBar'; | |||
import { Ajax } from 'src/libs/ajax'; | |||
import { Catalog } from 'src/libs/ajax/Catalog'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Catalog
is also imported from below, sonar flags this as a case where imports can be merged. Can you check and address sonar warnings added with this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, missed that. will do
removing ajax members (and related cleanup) will be the final PR after I remove some last references from within src/libs/ajax (mostly providers). I need to confirm some back-door AoU usage will be ok... a very small set will remain for some end2end test utility usage (which I am not pushing to remove yet).... but that can be from a demoted initAjaxForTesting function that is called from app startup.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you 👍
- minor import cleanup
Quality Gate passedIssues Measures |
Jira Ticket: https://broadworkbench.atlassian.net/browse/[Ticket #]
Summary of changes:
What
Why
Testing strategy