Partially revert "[DT-1122] Apply zizmor suggestions (#1879)"
#1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit 8501e14.
fboulnois
requested review from
rushtong and
rjohanek
and removed request for
a team
|
rjohanek
approved these changes
Jan 10, 2025
rjohanek
reviewed
Jan 10, 2025
| @@ -24,7 +24,6 @@ jobs: | |||
| with: | |||
| ref: develop | |||
| token: ${{ secrets.BROADBOT_TOKEN }} | |||
| persist-credentials: false | |||
There was a problem hiding this comment.
why remove this one specifically, this was the action that failed? do you know why it caused it to fail?
There was a problem hiding this comment.
The checkout action creates a GitHub token that can be used for other steps. The bumper needs the GitHub token to be able to bump the versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1122
Summary of changes
This partially reverts commit 8501e14. The bumper needs the GitHub token to be able to bump the versions.