Use spring HATEOAS to generate URIs for tests #1706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss level to bulk mock components that don't need stubbing
pshapiro4broad
requested review from
fboulnois and
okotsopoulos
and removed request for
a team
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always bugged me that we hardcode URIs in our webmvc tests, and recently I found that spring has a library that can do this for us. I also found that spring has a way to bulk declare all the components that need to be mocked while testing, which we can use for the cases where a mock doesn't need any stubs.
To show what this looks like, I picked a test with a single use case of webmvc. If this seems like a good idea, we can start using it it for new tests too.