-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies 2024-12-09 (#6750) #6769
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6769 +/- ##
========================================
Coverage 85.52% 85.52%
========================================
Files 153 153
Lines 21190 21190
========================================
Hits 18123 18123
Misses 3067 3067 ☔ View full report in Codecov by Sentry. |
0abb20a
to
d0a624f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subject: [PATCH] Document need to redeploy Data Browser after index (#6657)
---
Index: requirements.txt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/requirements.txt b/requirements.txt
--- a/requirements.txt (revision d0a624f69fae49baa871d7fc223b826a7626af7c)
+++ b/requirements.txt (date 1734502901084)
@@ -1,24 +1,24 @@
attrs==24.3.0
aws-requests-auth==0.4.3
bdbag==1.7.3
-boto3==1.35.82 # match this with the version of the `boto3-stubs` dev dependency
+boto3==1.35.82 # Match version of the `boto3-stubs` dev dependency
botocore==1.35.82
chevron==0.14.0
deprecated==1.2.15
-elasticsearch==7.17.12
-elasticsearch-dsl==7.4.1
+elasticsearch==7.17.12 # 7.x to match server-side
+elasticsearch-dsl==7.4.1 # 7.x to match server-side
fastavro==1.9.7
furl==2.1.3
google-api-core==2.24.0
google-auth[pyopenssl]==2.37.0
-google-cloud-bigquery==3.13.0 # Can't go higher, due to https://github.com/DataBiosphere/azul/issues/6709
+google-cloud-bigquery==3.13.0 # < 3.14.0, see https://github.com/DataBiosphere/azul/issues/6709
http-message-signatures==0.5.0
jmespath==1.0.1
more-itertools==10.5.0
msgpack==1.1.0
requests==2.32.3
-rsa==4.7.2 # resolve ambiguity with build-time dependency
-setuptools==70.3.0 # Keep consistent with requirements.pip.txt. Python 3.12 removed distutils, which we depended on transitively. Luckily, setuptools includes a vendored copy.
+rsa==4.7.2 # Resolve ambiguity with build-time dependency
+setuptools==70.3.0 # Match requirements.pip.txt. Python 3.12 removed distutils, which we depended on transitively. Luckily, setuptools includes a vendored copy.
urllib3==1.26.20
werkzeug==3.1.3
-r requirements.trans.txt
Index: requirements.pip.txt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/requirements.pip.txt b/requirements.pip.txt
--- a/requirements.pip.txt (revision d0a624f69fae49baa871d7fc223b826a7626af7c)
+++ b/requirements.pip.txt (date 1734502901092)
@@ -1,3 +1,3 @@
pip==24.0
-setuptools==70.3.0 # keep consistent with requirements.txt
+setuptools==70.3.0 # Match requirements.txt
wheel==0.38.4
Did you consider upgrading the pip dependencies?
requirements.txt
Outdated
@@ -20,5 +20,5 @@ requests==2.32.3 | |||
rsa==4.7.2 # resolve ambiguity with build-time dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try updating this? What are the version constraints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't 😅, but now did: #6774.
37dad84
to
0b6ff36
Compare
Negative. Is fixed now. |
Security design review
|
0b6ff36
to
e39203c
Compare
Connected issue: #6750
Checklist
Author
develop
upgrades/yyyy-mm-dd
Upgrade dependencies yyyy-mm-dd
Author (upgrading deployments)
make docker_images.json
and committed the resulting changes or this PR does not modifyazul_docker_images
, or any other variables referenced in the definition of that variableu
tag to commit title or this PR does not require upgrading deploymentsupgrade
or does not require upgrading deploymentsdeploy:shared
or does not modifydocker_images.json
, and does not require deploying theshared
component for any other reasondeploy:gitlab
or does not require deploying thegitlab
componentbackup:gitlab
deploy:runner
or does not require deploying therunner
imageAuthor (before every review)
develop
, squashed old fixupsmake requirements_update
or this PR does not modifyrequirements*.txt
,common.mk
,Makefile
andDockerfile
R
tag to commit title or this PR does not modifyrequirements*.txt
reqs
or does not modifyrequirements*.txt
make integration_test
passes in personal deployment or this PR does not modify functionality that could affect the IT outcomeSystem administrator (after approval)
no demo
Operator (before pushing merge the commit)
develop
_select dev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused
or this PR is not labeleddeploy:shared
_select dev.gitlab && python scripts/create_gitlab_snapshot.py --no-restart
(see operator manual for details) or this PR is not labeledbackup:gitlab
_select dev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply
or this PR is not labeleddeploy:gitlab
_select anvildev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused
or this PR is not labeleddeploy:shared
_select anvildev.gitlab && python scripts/create_gitlab_snapshot.py --no-restart
(see operator manual for details) or this PR is not labeledbackup:gitlab
_select anvildev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply
or this PR is not labeleddeploy:gitlab
deploy:gitlab
deploy:gitlab
System administrator
dev.gitlab
are complete or this PR is not labeleddeploy:gitlab
anvildev.gitlab
are complete or this PR is not labeleddeploy:gitlab
Operator (before pushing merge the commit)
_select dev.gitlab && make -C terraform/gitlab/runner
or this PR is not labeleddeploy:runner
_select anvildev.gitlab && make -C terraform/gitlab/runner
or this PR is not labeleddeploy:runner
sandbox
labeldev
anvildev
sandbox
deploymentanvilbox
deploymentsandbox
deploymentanvilbox
deploymentp
tagsOperator (after pushing the merge commit)
dev
anvildev
dev
dev
anvildev
anvildev
_select dev.shared && make -C terraform/shared apply
or this PR is not labeleddeploy:shared
_select anvildev.shared && make -C terraform/shared apply
or this PR is not labeleddeploy:shared
dev
anvildev
Operator
anvildev.shared
was last deployedscripts/export_inspector_findings.py
againstanvildev
, imported results to Google Sheet and posted screenshot of relevant1 findings as a comment on the connected issue.deploy:shared
,deploy:gitlab
,deploy:runner
andbackup:gitlab
labels to the next promotion PRs or this PR carries none of these labelsdeploy:shared
,deploy:gitlab
,deploy:runner
andbackup:gitlab
labels, from the description of this PR to that of the next promotion PRs or this PR carries none of these labels1A relevant finding is a high or critical vulnerability in an image
that is used within the security boundary. Images not used within the boundary
are tracked in
azul.docker_images
under a key starting with_
.System administrator
Shorthand for review comments
L
line is too longW
line wrapping is wrongQ
bad quotesF
other formatting problem