reports: dasharo-hcl-report: remove board_config call #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running HCL on platforms that are not listed in board_config ends on exiting the script. Calling that function was added while working on APU support, as there is multiple flash chip detected when try to use flashrom on that platform so chip name definition was added to specific platform in board_config. There is no need for that as check_flash_chip function check one by one known chips from the list defined as FLASH_CHIP_LIST (in dts_environment) and uses one, that does not return error when flashrom is invoked. Later in HCL we uses check_intel_regions func which needs PROGRAMMER_BIOS variable but this is by default defined in dts_enviroment as `internal` so in HCL we can assume to use this programmer for every platform. Signed-off-by: Tomasz Żyjewski <[email protected]>
|
Tested on APU, by running hcl there, logs - https://paste.dasharo.com/?753f7115cbea70bd#23UKN1Japa9iTDMoh85uLKaqzPSUwMxaRNFbUyp1uTuh Also tested on BoltGate machine (to check this on any, non supported platform), logs - https://paste.dasharo.com/?74b50160dbc6afe6#Ahngd5eh5G9R5pRhJSExUEANajqH9atRuGn9gpU27Tbi |
@macpijan, bad error handling might be the problem here. |
DaniilKl
approved these changes
Apr 18, 2024
macpijan
approved these changes
Apr 18, 2024
|
@DaniilKl you did approve this, can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running HCL on platforms that are not listed in board_config ends on exiting the script. Calling that function was added while working on APU support, as there is multiple flash chip detected when try to use flashrom on that platform so chip name definition was added to specific platform in board_config.
There is no need for that as check_flash_chip function check one by one known chips from the list defined as FLASH_CHIP_LIST (in dts_environment) and uses one, that does not return error when flashrom is invoked.
Later in HCL we uses check_intel_regions func which needs PROGRAMMER_BIOS variable but this is by default defined in dts_enviroment as
internalso in HCL we can assume to use this programmer for every platform.