Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw_data proc to builtin/builtin.odin #418

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

thetarnav
Copy link
Contributor

@thetarnav thetarnav commented Jun 30, 2024

Fixes #417

This works, but not without issues.

It does autocomplete, but it also shows completions for the private procs.

image

The hover info for returned value works only for a string source, every other overload just doesn't work.

@DanielGavin
Copy link
Owner

DanielGavin commented Jun 30, 2024

I think it works in rename branch. Atleast some of them. Don't think the simd one is supported yet.

@thetarnav
Copy link
Contributor Author

And do you know why the private procs are showing up? it is because builtin is being added to the „global scope” or something?

@DanielGavin
Copy link
Owner

DanielGavin commented Jun 30, 2024

Have you tried doing private="file"? It might treat the builtin as in the same package as the current one being edited.

@thetarnav
Copy link
Contributor Author

it does indeed help with autocomplete, but for some reason it completely disables hover info

@DanielGavin
Copy link
Owner

I'll have a look at that later.

@DanielGavin DanielGavin merged commit ee368d4 into DanielGavin:master Jul 1, 2024
5 checks passed
@thetarnav thetarnav deleted the raw_data branch July 2, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for raw_data macro
2 participants