Technical debt -- and one SPI bus fix #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overrides the weak definitions to ensure output over RTT.
Also fix `spi_nand_init()` so it doesn't try to release locks that it doesn't own....
henrygab
force-pushed
the
technical_debt
branch
from
e31663b to
984c2a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPI arbitration was broken. Turns out that releasing a mutex that hasn't been acquired is NOT the right thing to do, and then hiding the problem in a helper function just makes it that much harder to track down the real problem.
This branch also allows the buspirate's terminal to be controlled from RTT.
However, the terminal output is not yet sent over RTT ... so you'll still need to connect a terminal for now.
Related to #110 ... in that it may reduce corruption of the NAND file system by fixing the SPI arbitration.