Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2024 Standards #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update to 2024 Standards #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd845c0
Update to 2024 Standards
LanceMcCarthy Mar 21, 2024
16feec7
Update master.yml
LanceMcCarthy Mar 21, 2024
ed7c285
Update master.yml
LanceMcCarthy Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
on: push
on:
push:
workflow_dispatch:

name: master
jobs:
Expand All @@ -17,11 +19,16 @@ jobs:
- name: Run the action with missing certificate
uses: ./
with:
certificate: '${{ secrets.MISSING_CERTIFICATE }}'
certificate: ''
recursive: false
folder: 'files'
- name: Run the action
uses: ./
with:
certificate: '${{ secrets.CERTIFICATE }}'
password: '${{secrets.CERTIFICATE_PASSWORD}}'
certificatesha1: '${{secrets.CERTIFICATE_THUMBPRINT}}'
certificatename: '${{secrets.CERTIFICATE_NAME}}'
timestampUrl: "http://timestamp.digicert.com"
folder: 'files'
recursive: true
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ inputs:
required: false

runs:
using: 'node12'
using: 'node20'
main: 'dist/index.js'
4 changes: 3 additions & 1 deletion dist/index.js
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ async function addCertificateToStore(){
console.log(stdout);
return true;
} catch(err) {
console.log(err.stdout);
console.log(err.stderr);
console.log((err as any).stdout);
console.log((err as any).stderr);
return false;
}
}
Expand Down Expand Up @@ -82,8 +82,8 @@ async function signWithSigntool(fileName: string) {
console.log(stdout);
return true;
} catch(err) {
console.log(err.stdout);
console.log(err.stderr);
console.log((err as any).stdout);
console.log((err as any).stderr);
return false;
}
}
Expand Down
122 changes: 101 additions & 21 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
},
"homepage": "https://github.com/DanaBear/code-sign-action#readme",
"dependencies": {
"@actions/core": "^1.2.0"
"@actions/core": "^1.10.1"
},
"devDependencies": {
"@types/node": "^12.11.1",
"@zeit/ncc": "^0.20.5",
"typescript": "^3.6.4"
"@types/node": "^20.11.24",
"@vercel/ncc": "^0.38.1",
"typescript": "^5.3.3"
}
}