Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jdy8739] Week6 #905

Merged
merged 4 commits into from
Jan 18, 2025
Merged

[jdy8739] Week6 #905

merged 4 commits into from
Jan 18, 2025

Conversation

jdy8739
Copy link
Contributor

@jdy8739 jdy8739 commented Jan 14, 2025

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@jdy8739 jdy8739 requested a review from a team as a code owner January 14, 2025 14:39
@github-actions github-actions bot added the js label Jan 14, 2025
@jdy8739 jdy8739 requested a review from Jeldo January 14, 2025 14:43
Comment on lines +20 to +24
if (caseA || caseB || caseC) {
stack.pop();
} else {
return false;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else 없이 if 만 사용하면 가독성을 좀 더 올릴수 있지 않을까요 :)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 그렇겠네요 :) 피드백 감사합니다!

Copy link
Contributor

@TonyKim9401 TonyKim9401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6주차 문제 풀이 고생 많으셨습니다.
두 문제 모두 풀이가 간결하고 의도 전달이 뚜렸하여 리뷰하기 좋았습니다.
절반 정도의 기간 동안 고생 많으셨고 남은 8주도 파이팅입니다!

@jdy8739 jdy8739 merged commit 22fea49 into DaleStudy:main Jan 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants