[mallayon] Week 3 #792
Merged
[mallayon] Week 3 #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwbaik9717
reviewed
Dec 28, 2024
| */ | ||
|
|
||
| function productExceptSelf(nums: number[]): number[] { | ||
| let result: number[] = Array(nums.length).fill(1); |
There was a problem hiding this comment.
nums.length 가 여러번 쓰이는 것 같아요. 변수화를 통해 가독성을 조금 더 높여봐도 좋을 것 같아요!
There was a problem hiding this comment.
nums.length를 변수에 저장하는 것은 호불호가 갈릴 수도 있다는 생각이 들었습니다. 저는 오히려 기억해야 할 변수가 하나 줄어서 코드를 읽기 더 편했던 것 같아요 :)
|
@gwbaik9717 님, 답안 코드에 별 문제가 없으시다면 승인 좀 부탁드리겠습니다. |
gwbaik9717
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.