Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[정현준] 7주차 #488

Merged
merged 3 commits into from
Sep 28, 2024
Merged

[정현준] 7주차 #488

merged 3 commits into from
Sep 28, 2024

Conversation

jdalma
Copy link
Member

@jdalma jdalma commented Sep 23, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@jdalma jdalma marked this pull request as ready for review September 27, 2024 07:10
@jdalma jdalma requested a review from a team as a code owner September 27, 2024 07:10
@jdalma jdalma requested review from TonyKim9401 and removed request for kjb512 September 27, 2024 07:11
Copy link
Contributor

@TonyKim9401 TonyKim9401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdalma 님 리뷰어 제가 아니라 제 위에 계시던 Flynn님이세요~ 수정 부탁드려요 ㅎㅎ

@kjb512
Copy link
Contributor

kjb512 commented Sep 27, 2024

@jdalma 님 리뷰어 제가 아니라 제 위에 계시던 Flynn님이세요~ 수정 부탁드려요 ㅎㅎ

제가 #487 이여서 저인것 같습니다!

Copy link
Contributor

@kjb512 kjb512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
여러 가지 방법으로 고민하신 게 느껴집니다. 잘 해결하신 것 같아요!👍

maxLength = max(right - left + 1, maxLength)
used.add(s[right])
} else {
while (used.contains(s[right])) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s[right] in used 사용하는건 어떨까요? 가독성을 더 높일 수 있을 것 같습니다!

@jdalma jdalma merged commit b471b65 into DaleStudy:main Sep 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants