Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[강희찬] WEEK 4 Solution #416

Merged
merged 8 commits into from
Sep 5, 2024
Merged

[강희찬] WEEK 4 Solution #416

merged 8 commits into from
Sep 5, 2024

Conversation

HC-kang
Copy link
Contributor

@HC-kang HC-kang commented Sep 3, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@HC-kang HC-kang marked this pull request as ready for review September 4, 2024 14:15
@HC-kang HC-kang requested a review from a team as a code owner September 4, 2024 14:15
max = Math.max(num, max * num);
min = Math.min(num, min * num);

result = Math.max(result, max);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 따봉의 의미가 뭔지 궁금하네요 ㅋㅋ

@DaleSeo
Copy link
Contributor

DaleSeo commented Sep 4, 2024

문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.

체크가 되어 있는데 실제로는 안 되어 있는 것 같네요 🥲

Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

max = Math.max(num, max * num);
min = Math.min(num, min * num);

result = Math.max(result, max);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 따봉의 의미가 뭔지 궁금하네요 ㅋㅋ

*/
function isPalindrome(s: string): boolean {
function isAlNum(char: string): boolean {
return /^[a-zA-Z0-9]$/.test(char);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 자바스크립트 답안들은 대소 비교를 많이 했던데 정규식이 훨씬 깔끔하네요!

@HC-kang HC-kang merged commit 0f69d7f into DaleStudy:main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants