Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BedrockEconomyProvider to use AsyncAPI #13

Merged
merged 10 commits into from
Mar 8, 2024
Merged

Update BedrockEconomyProvider to use AsyncAPI #13

merged 10 commits into from
Mar 8, 2024

Conversation

Joestarfish
Copy link
Contributor

This should fix issue #12

@Aericio
Copy link
Collaborator

Aericio commented Mar 6, 2024

Seems like PHPStan is failing (workflow file is correct). Could you double check please?

Call to an undefined method cooldogedev\BedrockEconomy\currency\Currency::getDefaultBalance()

Not sure what the issue is with EconomyProvider, but you can leave that alone since this PR didn't change anything there.

@Joestarfish
Copy link
Contributor Author

I did not saw that. It should be good now.

Could you explain what you mean here? libPiggyEconomy seems to be crashing with the latest version of BedrockEconomy

Not sure what the issue is with EconomyProvider, but you can leave that alone since this PR didn't change anything there.

@Aericio
Copy link
Collaborator

Aericio commented Mar 7, 2024

I was referring to these two errors from PHPStan. Not sure what is up with this, since they're returning the expected values.
image

@Aericio
Copy link
Collaborator

Aericio commented Mar 7, 2024 •
edited
Loading

Seems like updating PMMP & PHPStan fixed it.

However, looks like there's still one more error with BedrockEconomy:
image

@Aericio
Copy link
Collaborator

Aericio commented Mar 7, 2024 •
edited
Loading

Tests are passing, nice! Thanks for fixing the errors. Will leave this for @DaPigGuy for final review.

@Aericio Aericio requested a review from DaPigGuy March 7, 2024 01:54
@DaPigGuy DaPigGuy linked an issue Mar 8, 2024 that may be closed by this pull request
Error in BedrockEconomyProvider line 27 #12
Closed
DaPigGuy
DaPigGuy approved these changes Mar 8, 2024
View reviewed changes
Copy link
Owner

@DaPigGuy DaPigGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaPigGuy DaPigGuy merged commit 9a22d3a into DaPigGuy:master Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaPigGuy DaPigGuy DaPigGuy approved these changes

Assignees
No one assigned
Labels
Type: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in BedrockEconomyProvider line 27
3 participants
@Joestarfish @Aericio @DaPigGuy