Support for NBT changes

DaPigGuy · Feb 17, 2018 · f594d36 · f594d36 · robske110 · Feb 18, 2018
1 parent 52e8a51
commit f594d36
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 21 deletions.
diff --git a/plugin.yml b/plugin.yml
@@ -1,6 +1,6 @@
 name: PiggyCustomEnchants
 main: PiggyCustomEnchants\Main
-version: 1.1.1
+version: 1.1.2
 api: 3.0.0-ALPHA11
 load: POSTWORLD
 author: DaPigGuy

diff --git a/src/PiggyCustomEnchants/Main.php b/src/PiggyCustomEnchants/Main.php
@@ -481,40 +481,30 @@ public function addEnchantment(Item $item, $enchants, $levels, $check = true, Co
                 if ($item->getId() == Item::BOOK) {
                     $item = Item::get(Item::ENCHANTED_BOOK, $level);
                 }
-                if (!$item->hasCompoundTag()) {
-                    $tag = new CompoundTag("", []);
-                } else {
-                    $tag = $item->getNamedTag();
-                }
-                if (!isset($tag->ench)) {
-                    $tag->ench = new ListTag("ench", []);
-                    $tag->ench->setTagType(NBT::TAG_Compound);
-                }
-                $found = false;
                 $ench = $item->getNamedTagEntry(Item::TAG_ENCH);
+                $found = false;
                 if (!($ench instanceof ListTag)) {
                     $ench = new ListTag(Item::TAG_ENCH, [], NBT::TAG_Compound);
                 } else {
                     foreach ($ench as $k => $entry) {
                         if ($entry->getShort("id") === $enchant->getId()) {
-                            $ench[$k] = new CompoundTag("", [
+                            $ench->set($k, new CompoundTag("", [
                                 new ShortTag("id", $enchant->getId()),
                                 new ShortTag("lvl", $level)
-                            ]);
+                            ]));
                             $item->setCustomName(str_replace($this->getRarityColor($enchant->getRarity()) . $enchant->getName() . " " . $this->getRomanNumber($entry["lvl"]), $this->getRarityColor($enchant->getRarity()) . $enchant->getName() . " " . $this->getRomanNumber($level), $item->getName()));
                             $found = true;
                             break;
                         }
                     }
                 }
                 if (!$found) {
-                    $ench[count($ench)] = new CompoundTag("", [
+                    $ench->push(new CompoundTag("", [
                         new ShortTag("id", $enchant->getId()),
                         new ShortTag("lvl", $level)
-                    ]);
+                    ]));
                     $item->setCustomName($item->getName() . "\n" . $this->getRarityColor($enchant->getRarity()) . $enchant->getName() . " " . $this->getRomanNumber($level));
                 }
-                $item->setNamedTagEntry($ench);
                 if ($sender !== null) {
                     $sender->sendMessage(TextFormat::GREEN . "Enchanting succeeded.");
                 }
@@ -558,13 +548,18 @@ public function removeEnchantment(Item $item, $enchant, $level = -1)
         if ($enchant instanceof EnchantmentInstance) {
             $enchant = $enchant->getType();
         }
-        $tag = $item->getNamedTag();
-        $item = Item::get($item->getId(), $item->getDamage(), $item->getCount());
-        foreach ($tag->ench as $k => $enchantment) {
-            if (($enchantment["id"] == $enchant->getId() && ($enchantment["lvl"] == $level || $level == -1)) !== true) {
-                $item = $this->addEnchantment($item, $enchantment["id"], $enchantment["lvl"], true);
+        $ench = $item->getNamedTagEntry(Item::TAG_ENCH);
+        if (!($ench instanceof ListTag)) {
+            return false;
+        }
+        foreach ($ench as $k => $entry) {
+            if ($entry->getShort("id") === $enchant->getId() and ($level === -1 or $entry->getShort("lvl") === $level)) {
+                $ench->remove($k);
+                $item->setCustomName(str_replace("\n" . $this->getRarityColor($enchant->getRarity()) . $enchant->getName() . " " . $this->getRomanNumber($entry->getShort("lvl")), "", $item->getCustomName()));
+                break;
             }
         }
+        $item->setNamedTagEntry($ench);
         return $item;
     }