Fixing issue #353 Forward Slash in site or channel name causes recording error #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved replaceIllegalCharacters method into StringUtils. Modified classes that write out to disk to call this method when saving a file.
DSheirer
reviewed
Dec 15, 2018
| @@ -225,7 +226,7 @@ private String getFilePrefix(ReusableAudioPacket packet) | |||
| } | |||
| } | |||
|
|
|||
| return sb.toString(); | |||
| return StringUtils.replaceIllegalCharacters(sb.toString()); | |||
There was a problem hiding this comment.
Could you please move the clean method to where each of the System/Site/Name values are added. Otherwise, the clean method causes invalid linux filepaths.
sb.append(metadata.hasChannelConfigurationSystem() ? StringUtils.replaceIllegalCharacters(metadata.getChannelConfigurationSystem()) + "_" : "");
sb.append(metadata.hasChannelConfigurationSite() ? StringUtils.replaceIllegalCharacters(metadata.getChannelConfigurationSite()) + "_" : "");
sb.append(metadata.hasChannelConfigurationName() ? StringUtils.replaceIllegalCharacters(metadata.getChannelConfigurationName()) + "_" : "");
There was a problem hiding this comment.
I changed this suggestion a little bit to encompass the 'metadata.getPrimaryAddressTo().getIdentifier()' calls as well. My thinking is that it may somehow be possible to have an illegal char in the identifier.
src/main/java/io/github/dsheirer/record/wave/AudioPacketWaveRecorder.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/dsheirer/record/wave/ComplexBufferWaveRecorder.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved replaceIllegalCharacters method into StringUtils.
Modified classes that write out to disk to call this method when saving a file.