Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the InvisibleTextItem #80

Closed
wants to merge 2 commits into from
Closed

Conversation

PeterStaar-IBM
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM commented Dec 1, 2024

Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM PeterStaar-IBM marked this pull request as draft December 2, 2024 08:40
@PeterStaar-IBM
Copy link
Contributor Author

@vagenas can you add the issue wrt word comments?

@vagenas
Copy link
Collaborator

vagenas commented Dec 2, 2024

It was not a GitHub issue, but rather an internal discussion — shared it privately now 😉


def __str__(self):
"""Get string value."""
return str(self.value)


class InvisibleTextLabel(str, Enum):
Copy link
Contributor

@cau-git cau-git Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not introduce an additional dimension just forInvisibleTextLabel, let's avoid to have a second-level dependency to DocItemLabel.INVISIBLE_TEXT, and just put straight:

DocItemLabel.COMMENT # For speech-bubble comments where supported (we could enable it for some backends)
DocItemLabel.NOTE # For author or slide notes

as regular labels. Then, we can add these to the furniture (same as for heading or footers) and enable that the furniture can be iterated over together with the rest.

Copy link

mergify bot commented Dec 13, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Enforce conventional commit

This rule is failing.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@cau-git
Copy link
Contributor

cau-git commented Dec 17, 2024

Agreements from discussion:

  • There should be no third category of labels.
  • Things like slide comments, Word review comments, etc. should go into the furniture root and be put inside a group with new GroupLabel.COMMENT_SECTION
  • Optional: We can extend the type hierachy with a CommentItem, which additionally stores an author name and timestamp with the text.
  • We must add filter argument for group labels on the export functions (additional to DocItemLabels)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants