-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the InvisibleTextItem #80
Conversation
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
@vagenas can you add the issue wrt word comments? |
It was not a GitHub issue, but rather an internal discussion — shared it privately now 😉 |
|
||
def __str__(self): | ||
"""Get string value.""" | ||
return str(self.value) | ||
|
||
|
||
class InvisibleTextLabel(str, Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not introduce an additional dimension just forInvisibleTextLabel
, let's avoid to have a second-level dependency to DocItemLabel.INVISIBLE_TEXT
, and just put straight:
DocItemLabel.COMMENT # For speech-bubble comments where supported (we could enable it for some backends)
DocItemLabel.NOTE # For author or slide notes
as regular labels. Then, we can add these to the furniture (same as for heading or footers) and enable that the furniture can be iterated over together with the rest.
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Enforce conventional commitThis rule is failing.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
|
Agreements from discussion:
|
Project
Adding the ability to add Invisible text.
Resolves/Required by