-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host a working version #1
base: master
Are you sure you want to change the base?
Conversation
136737c
to
d21a108
Compare
.gitignore
Outdated
lib/**/* | ||
|
||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: would be good to add a newline here.
@@ -17,6 +17,9 @@ export async function runOnBlame(files: string[]): Promise<void> { | |||
core.getInput('phpcs_path', { required: true }) | |||
); | |||
|
|||
const dontFailOnError = | |||
core.getInput('fail_on_errors') == 'false' || | |||
core.getInput('fail_on_errors') === 'off'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really great to use double negatives in variable names, but given that dontFailOnWarning
already exists, meh.
Although given that this is later only used as !dontFailOnError
I think it's actually better to simply name it failOnError
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree but the original author already had this, I only intended to add a "copy" which works the same as the warning option.
const failOnError = core.getInput('fail_on_errors'); | ||
if (failOnError == 'false' || failOnError === 'off') { | ||
args.push('--runtime-set ignore_errors_on_exit 1'); | ||
} | ||
const failOnWarning = core.getInput('fail_on_warnings'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such consistency by the original author...
Updated the npm packages. This commit can be removed when the upstream action works again. Afterwards run `npm install && npm run all`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This version will not break on errors or warnings.