Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should not calculate earlyness for far away trains #46

Closed
DKFN opened this issue Jan 9, 2023 · 4 comments
Closed

We should not calculate earlyness for far away trains #46

DKFN opened this issue Jan 9, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@DKFN
Copy link
Owner

DKFN commented Jan 9, 2023

It is useless to calculate the earlyness of a train if it is not around the station, this data servers no purpose.
Reported my @marass007
@DKFN DKFN added enhancement New feature or request Priority labels Jan 9, 2023
@Tallyrald
Copy link
Collaborator

How do we define not being around the station? Distance? Arriving/leaving a neighbouring station?

@DKFN
Copy link
Owner Author

DKFN commented Jan 10, 2023

I think we will go with distance but I'll remove this from priority as I think it indeed needs more information to be able to make it good ! :)

@DKFN DKFN removed the Priority label Jan 10, 2023
@Tallyrald
Copy link
Collaborator

This is related to #63 , but it will still be a valid issue even after proper early/late calculations are implemented.

@itsP33t itsP33t mentioned this issue Feb 12, 2023
Open
@itsP33t
Copy link
Collaborator

itsP33t commented Feb 12, 2023

Moved to simrail/EDR#39

@itsP33t itsP33t closed this as completed Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DKFN @Tallyrald @itsP33t