Update test classes, disable tests needing investigation

Disabled two tests in the 'SendChunkedMessageTest' and 'SendChunkedMessageForSingleChunkTest' classes needing further investigation and attributed them to issues #197 and #198 respectively. Created 'SendChunkedMessageForSingleChunkTest' file. Changed the error code assertion from string to integer in 'OnboardingWithErrorMessageTest'.
DKE-Data · Dec 15, 2023 · fdb6260 · fdb6260
1 parent 4a9e87f
commit fdb6260
Show file tree

Hide file tree

Showing 3 changed files with 114 additions and 3 deletions.
diff --git a/...ava/com/dke/data/agrirouter/test/messaging/rest/SendChunkedMessageForSingleChunkTest.java b/...ava/com/dke/data/agrirouter/test/messaging/rest/SendChunkedMessageForSingleChunkTest.java
@@ -0,0 +1,111 @@
+package com.dke.data.agrirouter.test.messaging.rest;
+
+import agrirouter.request.Request;
+import com.dke.data.agrirouter.api.cancellation.DefaultCancellationToken;
+import com.dke.data.agrirouter.api.dto.encoding.DecodeMessageResponse;
+import com.dke.data.agrirouter.api.dto.messaging.FetchMessageResponse;
+import com.dke.data.agrirouter.api.dto.onboard.OnboardingResponse;
+import com.dke.data.agrirouter.api.enums.ContentMessageType;
+import com.dke.data.agrirouter.api.enums.SystemMessageType;
+import com.dke.data.agrirouter.api.service.messaging.encoding.DecodeMessageService;
+import com.dke.data.agrirouter.api.service.messaging.encoding.EncodeMessageService;
+import com.dke.data.agrirouter.api.service.messaging.http.FetchMessageService;
+import com.dke.data.agrirouter.api.service.parameters.MessageHeaderParameters;
+import com.dke.data.agrirouter.api.service.parameters.MessageParameterTuple;
+import com.dke.data.agrirouter.api.service.parameters.PayloadParameters;
+import com.dke.data.agrirouter.api.service.parameters.SendMessageParameters;
+import com.dke.data.agrirouter.impl.common.MessageIdService;
+import com.dke.data.agrirouter.impl.messaging.SequenceNumberService;
+import com.dke.data.agrirouter.impl.messaging.encoding.DecodeMessageServiceImpl;
+import com.dke.data.agrirouter.impl.messaging.encoding.EncodeMessageServiceImpl;
+import com.dke.data.agrirouter.impl.messaging.rest.FetchMessageServiceImpl;
+import com.dke.data.agrirouter.impl.messaging.rest.SendMessageServiceImpl;
+import com.dke.data.agrirouter.test.AbstractIntegrationTest;
+import com.dke.data.agrirouter.test.Assertions;
+import com.dke.data.agrirouter.test.OnboardingResponseRepository;
+import com.dke.data.agrirouter.test.helper.ContentReader;
+import com.google.protobuf.ByteString;
+import org.apache.http.HttpStatus;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+import java.util.*;
+import java.util.concurrent.atomic.AtomicReference;
+
+/**
+ * Test case to show the behavior for chunked message sending.
+ */
+class SendChunkedMessageForSingleChunkTest extends AbstractIntegrationTest {
+
+    private static final int MAX_CHUNK_SIZE = 1024000;
+
+    @Test
+    @Disabled("Issue #198 | Needs investigation, not running any longer.")
+    void
+    givenSmallContentMessageWhenSendingTheMessageToTheAgrirouterTheSdkShouldHelpToSendTheFileInOneChunk()
+            throws Throwable {
+
+        final EncodeMessageService encodeMessageService = new EncodeMessageServiceImpl();
+        final SendMessageServiceImpl sendMessageService = new SendMessageServiceImpl();
+        final OnboardingResponse onboardingResponse =
+                OnboardingResponseRepository.read(OnboardingResponseRepository.Identifier.FARMING_SOFTWARE);
+
+        MessageHeaderParameters messageHeaderParameters = new MessageHeaderParameters();
+        messageHeaderParameters.setTechnicalMessageType(ContentMessageType.ISO_11783_TASKDATA_ZIP);
+        messageHeaderParameters.setApplicationMessageId(MessageIdService.generateMessageId());
+        messageHeaderParameters.setApplicationMessageSeqNo(
+                SequenceNumberService.generateSequenceNumberForEndpoint(onboardingResponse));
+        messageHeaderParameters.setMode(Request.RequestEnvelope.Mode.DIRECT);
+        messageHeaderParameters.setRecipients(
+                Collections.singletonList("797b7f4b-79ec-4247-9fba-e726a55c4c7f"));
+
+        PayloadParameters payloadParameters = new PayloadParameters();
+        payloadParameters.setValue(
+                ByteString.copyFrom(ContentReader.readRawData(ContentReader.Identifier.SMALL_TASK_DATA)));
+        payloadParameters.setTypeUrl(SystemMessageType.EMPTY.getKey());
+
+        List<MessageParameterTuple> tuples =
+                encodeMessageService.chunkAndBase64EncodeEachChunk(
+                        messageHeaderParameters, payloadParameters, onboardingResponse);
+
+        tuples.forEach(
+                messageParameterTuple ->
+                        Assertions.assertTrue(
+                                Objects.requireNonNull(messageParameterTuple.getPayloadParameters().getValue())
+                                        .toStringUtf8()
+                                        .length()
+                                        <= MAX_CHUNK_SIZE));
+
+        List<String> encodedMessages = encodeMessageService.encode(tuples);
+
+        SendMessageParameters sendMessageParameters = new SendMessageParameters();
+        sendMessageParameters.setEncodedMessages(encodedMessages);
+        sendMessageParameters.setOnboardingResponse(onboardingResponse);
+        sendMessageService.send(sendMessageParameters);
+
+        waitForTheAgrirouterToProcessMultipleMessages();
+
+        FetchMessageService fetchMessageService = new FetchMessageServiceImpl();
+        Optional<List<FetchMessageResponse>> fetchMessageResponses =
+                fetchMessageService.fetch(
+                        onboardingResponse,
+                        new DefaultCancellationToken(MAX_TRIES_BEFORE_FAILURE, DEFAULT_INTERVAL));
+
+        Assertions.assertTrue(fetchMessageResponses.isPresent());
+        Assertions.assertEquals(1, fetchMessageResponses.get().size());
+
+        DecodeMessageService decodeMessageService = new DecodeMessageServiceImpl();
+        AtomicReference<DecodeMessageResponse> decodeMessageResponse = new AtomicReference<>();
+        fetchMessageResponses.get().stream()
+                .map(FetchMessageResponse::getCommand)
+                .forEach(
+                        message -> {
+                            Assertions.assertNotNull(message);
+                            decodeMessageResponse.set(decodeMessageService.decode(message.getMessage()));
+
+                            Assertions.assertMatchesAny(
+                                    Arrays.asList(HttpStatus.SC_OK, HttpStatus.SC_CREATED, HttpStatus.SC_NO_CONTENT),
+                                    decodeMessageResponse.get().getResponseEnvelope().getResponseCode());
+                        });
+    }
+}
diff --git a/...sts/src/test/java/com/dke/data/agrirouter/test/messaging/rest/SendChunkedMessageTest.java b/...sts/src/test/java/com/dke/data/agrirouter/test/messaging/rest/SendChunkedMessageTest.java
@@ -39,10 +39,10 @@ class SendChunkedMessageTest extends AbstractIntegrationTest {
 
     private static final int MAX_CHUNK_SIZE = 1024000;
 
-    @Disabled("Currently there is a mismatch between the chunks and the messages.")
     @Test
+    @Disabled("Issue #197 | Needs investigation, not running any longer.")
     void
-    givenLargeContentMessageWhenSendingTheMessageToTheAgrirouterTheSdkShouldHelpToSendTheFileInMultipleChunks()
+    givenLargeContentMessageWhenSendingTheMessageToTheAhrgrirouterTheSdkShouldHelpToSendTheFileInMultipleChunks()
             throws Throwable {
 
         final EncodeMessageService encodeMessageService = new EncodeMessageServiceImpl();

diff --git a/...src/test/java/com/dke/data/agrirouter/test/onboarding/OnboardingWithErrorMessageTest.java b/...src/test/java/com/dke/data/agrirouter/test/onboarding/OnboardingWithErrorMessageTest.java
@@ -36,7 +36,7 @@ class OnboardingWithErrorMessageTest extends AbstractIntegrationTest {
                         OnboardingException.class, () -> onboardingService.onboard(onboardingParameters));
         Assertions.assertNotNull(onboardingException.getOnboardingError());
         Assertions.assertNotNull(onboardingException.getOnboardingError().getError());
-        Assertions.assertEquals("0401", onboardingException.getOnboardingError().getError().getCode());
+        Assertions.assertEquals(401, onboardingException.getOnboardingError().getError().getCode());
         Assertions.assertEquals(
                 "Bearer not found.", onboardingException.getOnboardingError().getError().getMessage());
     }