Fix Makeown-ing an enemy of civilization constantly producing vengeful thoughts #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns (for now, added THIEF for goblin snatchers)
myk002
reviewed
Jun 28, 2024
|
also needs changelog entry |
|
you can set vscode to remove trailing spaces on save. That might help you pass the pre-commit.ci check with more consistency. |
myk002
reviewed
Jul 2, 2024
myk002
reviewed
Jul 19, 2024
Crystalwarrior
changed the title
myk002
reviewed
Jan 28, 2025
myk002
reviewed
Jan 30, 2025
| @@ -280,7 +280,7 @@ local function fix_histfig(unit) | |||
| ::continue:: | |||
| end | |||
| -- If you're makeown-ing an enemy of your civilization or group, people will feel vengeful without this | |||
| if df.histfig_entity_link_enemyst:is_instance(el) then | |||
| if el and df.histfig_entity_link_enemyst:is_instance(el) then | |||
There was a problem hiding this comment.
This does not fix the problem. el can be a stale reference. the call to entity_link above can delete the memory that el points to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spam of vengeful thoughts when makeown()ing an enemy of your civilization/group.