Induction question changes #7401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleMacPherson
force-pushed
the
induction-year-question
branch
from
1ad13e9 to
340b96b
Compare
KyleMacPherson
had a problem deploying
to
review
GitHub Actions
Failure
…duction completion in their jobseeker profile
…te_details is set to nil when statutory_induction_complete is "yes" and add tests
KyleMacPherson
force-pushed
the
induction-year-question
branch
from
340b96b to
5a35518
Compare
|
Review app https://teaching-vacancies-review-pr-7401.test.teacherservices.cloud was successfully deleted |
…od question on their profile
…_induction_complete == "no"
KyleMacPherson
changed the title
KyleMacPherson
changed the title
scruti
reviewed
Jan 14, 2025
config/locales/forms.yml
Outdated
| @@ -532,12 +532,12 @@ en: | |||
| non_teacher: I'm not looking for a teaching job | |||
| "yes": "Yes" | |||
| statutory_induction_complete_options: | |||
| "no": "No" | |||
| "no": "No, I have not completed my induction period" | |||
| on_track: I'm on track to complete it | |||
There was a problem hiding this comment.
I believe we have stopped using this?
Suggested change
| on_track: I'm on track to complete it |
scruti
reviewed
Jan 14, 2025
config/locales/forms.yml
Outdated
| @@ -598,16 +598,18 @@ en: | |||
| on_track: "I’m on track to receive QTS" | |||
| non_teacher: "I'm not looking for a teaching job" | |||
| statutory_induction_complete_options: | |||
| "no": "No or not applicable" | |||
| "no": "No, I have not completed my induction period" | |||
| on_track: I'm on track to complete it | |||
There was a problem hiding this comment.
✂️ ?
Suggested change
| on_track: I'm on track to complete it |
scruti
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/177qqq8e/1477-update-induction-year-question-in-professional-status-section-application-and-profiles
Changes in this PR:
This PR:
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?