Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Awarding Body to qualification result #7352

Merged
merged 14 commits into from
Jan 14, 2025

Conversation

starswan
Copy link
Contributor

@starswan starswan commented Dec 16, 2024

Trello card URL

https://trello.com/c/BKrMfPoz/1438-add-awarding-body-and-design-changes-to-gcse-page-application-and-profiles

Changes in this PR:

  • Is there anything specific you want feedback on?

Screenshots of UI changes:

Before

QualliesBefore

After

QualliesAfter

Next steps:

  • Terraform deployment required?

  • New development configuration to be shared?

@starswan starswan changed the title Phase I - add extra field to qualification result Add Awarding Body to qualification result Dec 16, 2024
@starswan starswan force-pushed the add-awarding-body-to-qualifications branch 2 times, most recently from 21d61d3 to d0ca54e Compare December 20, 2024 13:06
@starswan starswan marked this pull request as ready for review December 20, 2024 14:27
@starswan starswan force-pushed the add-awarding-body-to-qualifications branch 2 times, most recently from 57fc578 to e462e67 Compare January 6, 2025 09:20
@starswan starswan added the deploy label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Review app https://teaching-vacancies-review-pr-7352.test.teacherservices.cloud was successfully deleted

@starswan starswan force-pushed the add-awarding-body-to-qualifications branch from e462e67 to 54d25fb Compare January 7, 2025 08:49
Copy link
Collaborator

@scruti scruti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some test coverage on this new field filling?

Copy link
Collaborator

@scruti scruti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@starswan starswan force-pushed the add-awarding-body-to-qualifications branch from b9aa30e to 2f0bf5a Compare January 13, 2025 15:48
@starswan starswan force-pushed the add-awarding-body-to-qualifications branch from 2f0bf5a to 860e25e Compare January 13, 2025 16:05
@starswan starswan merged commit 9b0ff39 into main Jan 14, 2025
13 checks passed
@starswan starswan deleted the add-awarding-body-to-qualifications branch January 14, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants