-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Awarding Body to qualification result #7352
Conversation
21d61d3
to
d0ca54e
Compare
57fc578
to
e462e67
Compare
Review app https://teaching-vacancies-review-pr-7352.test.teacherservices.cloud was successfully deleted |
e462e67
to
54d25fb
Compare
app/controllers/jobseekers/profiles/qualifications_controller.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some test coverage on this new field filling?
54d25fb
to
982c5d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
b9aa30e
to
2f0bf5a
Compare
2f0bf5a
to
860e25e
Compare
Trello card URL
https://trello.com/c/BKrMfPoz/1438-add-awarding-body-and-design-changes-to-gcse-page-application-and-profiles
Changes in this PR:
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?