Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GovukNotify from 7.1.0 to 7.2.0 #1460

Merged
merged 1 commit into from
Sep 30, 2024
+1 −1
Merged

Bump GovukNotify from 7.1.0 to 7.2.0 #1460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GetIntoTeachingApi/GetIntoTeachingApi.csproj
View file
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@
</PackageReference>
<PackageReference Include="PropertyChanged.Fody" Version="4.1.0" PrivateAssets="All" />
<PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="3.0.1" />
<PackageReference Include="GovukNotify" Version="7.1.0" />
<PackageReference Include="GovukNotify" Version="7.2.0" />
<PackageReference Include="Flurl.Http" Version="4.0.2" />
<PackageReference Include="AspNetCoreRateLimit.Redis" Version="2.0.0" />
<PackageReference Include="Hangfire.Dashboard.Basic.Authentication" Version="7.0.1" />

Unchanged files with check annotations Beta

View file
Dockerfile
ENTRYPOINT ["dotnet", "GetIntoTeachingApi.dll"]
ENV ASPNETCORE_URLS=http://+:8080
ARG GIT_COMMIT_SHA
ENV GIT_COMMIT_SHA ${GIT_COMMIT_SHA}

Check warning on line 25 in Dockerfile

GitHub Actions / Build and push to Github Container Registry

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
View file
GetIntoTeachingApi/Models/TeacherTrainingAdviser/TeacherTrainingAdviserSignUp.cs
[SwaggerSchema(WriteOnly = true)]
public DateTime? PhoneCallScheduledAt { get; set; }
[SwaggerSchema(ReadOnly = true)]
public bool CanSubscribeToTeacherTrainingAdviser { get; set; }

Check warning on line 82 in GetIntoTeachingApi/Models/TeacherTrainingAdviser/TeacherTrainingAdviserSignUp.cs

GitHub Actions / sonarcloud 

Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[SwaggerSchema(ReadOnly = true)]
public int? AssignmentStatusId { get; set; }
View file
GetIntoTeachingApi/Models/SchoolsExperience/SchoolsExperienceSignUp.cs
public Guid? MasterId { get; set; }
[SwaggerSchema(ReadOnly = true)]
public bool Merged { get; set; }

Check warning on line 21 in GetIntoTeachingApi/Models/SchoolsExperience/SchoolsExperienceSignUp.cs

GitHub Actions / sonarcloud 

Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[SwaggerSchema(ReadOnly = true)]
public string FullName { get; set; }
public string Email { get; set; }
View file
GetIntoTeachingApi/Models/IAppSettings.cs
{
DateTime? ApplyLastSyncAt { get; set; }
DateTime? CrmIntegrationPausedUntil { get; set; }
bool IsApplyBackfillInProgress { get; set; }

Check warning on line 9 in GetIntoTeachingApi/Models/IAppSettings.cs

GitHub Actions / sonarcloud 

Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
bool IsCrmIntegrationPaused { get; }
}
}
View file
GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs
public string AddressTelephone { get; set; }
public bool IsVerified { get; set; } = true;
[SwaggerSchema(WriteOnly = true)]
public bool IsWalkIn { get; set; }

Check warning on line 36 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud 

Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[SwaggerSchema(WriteOnly = true)]
public bool SubscribeToMailingList { get; set; }

Check warning on line 38 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud 

Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[SwaggerSchema(ReadOnly = true)]
public bool AlreadySubscribedToEvents { get; set; }

Check warning on line 40 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud 

Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[SwaggerSchema(ReadOnly = true)]
public bool AlreadySubscribedToMailingList { get; set; }

Check warning on line 42 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud 

Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[SwaggerSchema(ReadOnly = true)]
public bool AlreadySubscribedToTeacherTrainingAdviser { get; set; }

Check warning on line 44 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud 

Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[JsonIgnore]
public Candidate Candidate => CreateCandidate();
View file
GetIntoTeachingApi/Models/Crm/TeachingEvent.cs
}
[EntityField("dfe_event_type", typeof(OptionSetValue))]
public int TypeId { get; set; }

Check warning on line 38 in GetIntoTeachingApi/Models/Crm/TeachingEvent.cs

GitHub Actions / sonarcloud 

Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[EntityField("dfe_eventstatus", typeof(OptionSetValue))]
public int StatusId { get; set; }

Check warning on line 40 in GetIntoTeachingApi/Models/Crm/TeachingEvent.cs

GitHub Actions / sonarcloud 

Value type property used as input in a controller action should be nullable, required or annotated with the JsonRequiredAttribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[EntityField("dfe_eventregion", typeof(OptionSetValue))]
public int? RegionId { get; set; }
[EntityField("dfe_websiteeventpartialurl")]