ER 887 Account Page #977
ER 887 Account Page #977
Conversation
|
Changes preview: Legend: |
jack-coggin
temporarily deployed
to
development
GitHub Actions
Inactive
config/locales/en.yml
Outdated
| @@ -296,6 +296,7 @@ en: | |||
| # /my-account | |||
| my_account: | |||
| title: My account | |||
| name_information: This is the name that will appear on you end of module certificate. You can use this setting to change how your name appears. Changing your name on this account will not affect your Gov.UK One Login account. | |||
There was a problem hiding this comment.
I believe that the GOV.UK One Login is always capitalised i.e. the GOV part
app/views/user/show.html.slim
Outdated
There was a problem hiding this comment.
For consistency in the layout the HR on line 10 needs the margin bottom to be removed. Add the class: govuk-!-margin-bottom-0 to it
There was a problem hiding this comment.
Thanks @instantrick 4a353bc
jack-coggin
temporarily deployed
to
development
GitHub Actions
Inactive
| @@ -1,55 +0,0 @@ | |||
| require 'rails_helper' | |||
There was a problem hiding this comment.
We have removed the link on the account page at this point, but the route and functionality remains. I think if that is the case we shouldn't be deleting the spec, which I presume still works?
| @@ -14,7 +15,7 @@ | |||
|
|
|||
| it 'is not redirected and can access secure pages' do | |||
| expect(response).not_to redirect_to new_user_session_path | |||
| expect(response.body).to include bot_email | |||
| expect(response.body).to include bot_name | |||
There was a problem hiding this comment.
What makes this necessary?
There was a problem hiding this comment.
@peterdavidhamilton Email is no longer displayed on account page, so using the name to identify the user in this case instead
jack-coggin
temporarily deployed
to
development
GitHub Actions
Inactive
jack-coggin
had a problem deploying
to
production
GitHub Actions
Failure
ER-887
Update account page to remove options for updating email and password ready for Gov One login move