Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER-467 New Module Indicator #924

Merged
merged 30 commits into from
Dec 5, 2023
Merged

ER-467 New Module Indicator #924

merged 30 commits into from
Dec 5, 2023

Conversation

jack-coggin
Copy link
Contributor

@jack-coggin jack-coggin commented Oct 25, 2023

ER-467

  • Add new indicator tag for modules released since user's last visit
  • Add content_changes service to get the changes since the user's last visit

@viezly
Copy link

viezly bot commented Oct 25, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@jack-coggin jack-coggin changed the title New Module Indicator Identify new module for user Oct 25, 2023
@jack-coggin jack-coggin changed the title Identify new module for user New Module Indicator Nov 23, 2023
@jack-coggin jack-coggin added the review Review app deployed to Azure label Nov 23, 2023
Copy link

@jack-coggin jack-coggin marked this pull request as ready for review November 23, 2023 16:12
@instantrick
Copy link

@jack-coggin All formatting is fine but there is a nuance in the logic that you might need to look at. It simply should not be possible for a module to be in progress AND be showing the NEW indicator - this might be addressed by you restoring the code that checks the status but I thought I better flag it.

image

@jack-coggin
Copy link
Contributor Author

@jack-coggin All formatting is fine but there is a nuance in the logic that you might need to look at. It simply should not be possible for a module to be in progress AND be showing the NEW indicator - this might be addressed by you restoring the code that checks the status but I thought I better flag it.

image

Thanks @instantrick it won't be - it will only be applied to cards in the available section. Since the specific QA scenarios might be more complicated to setup I thought it would be best to check the styling is correct first, so I have removed the logic for now and applied the tag to all cards

@github-actions github-actions bot added the pipeline Github workflow changes label Dec 5, 2023
@github-actions github-actions bot removed the terraform Changes to Terraform detected label Dec 5, 2023
@jack-coggin jack-coggin changed the title New Module Indicator ER-467 New Module Indicator Dec 5, 2023
@jack-coggin jack-coggin added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit 9475685 Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Changes to assets detected review Review app deployed to Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants