Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER-413 Gov one login Integration #917

Merged
merged 139 commits into from
Dec 21, 2023
Merged

ER-413 Gov one login Integration #917

merged 139 commits into from
Dec 21, 2023

Conversation

jack-coggin
Copy link
Contributor

@jack-coggin jack-coggin commented Oct 24, 2023

Add gov one login authentication option with one login integration environment. Also adds bridging page and t&c page and updates homepage and user account page.

The bridging page can be accessed at /gov-one/info of from the sign in links

Requires GOV_ONE_LOGIN env variable feature flag


For further information and technical checklist see gov_one_login/GOV_ONE_LOGIN.MD

@jack-coggin jack-coggin changed the title ER-413 One login Integration ER-413 Gov one login Integration Oct 24, 2023
@viezly
Copy link

viezly bot commented Oct 24, 2023

This pull request is split into 5 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • app
  • config
  • db
  • spec

Copy link
Contributor

@peterdavidhamilton peterdavidhamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemfile.lock got deleted.

.gitignore Outdated Show resolved Hide resolved
db/migrate/20231031094611_add_id_token_to_users.rb Outdated Show resolved Hide resolved
app/views/gov_one/info.html.slim Outdated Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
app/services/gov_one_auth_service.rb Outdated Show resolved Hide resolved
app/services/gov_one_auth_service.rb Outdated Show resolved Hide resolved
@peterdavidhamilton
Copy link
Contributor

One error is a timeout on the CMS, if that happens just rerun it. Another spec failed on a count of locale. As you may add some new ones perhaps add a quick inventory in the PR description so Content can create them.

adr/ADR.md Outdated Show resolved Hide resolved
Copy link
Contributor

@martikat martikat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I have run this locally and created a new account when checking this in the review app

@jack-coggin jack-coggin added this pull request to the merge queue Dec 21, 2023
Merged via the queue into main with commit 4303347 Dec 21, 2023
3 of 4 checks passed
@peterdavidhamilton peterdavidhamilton deleted the one-login branch December 21, 2023 16:23
@jack-coggin jack-coggin restored the one-login branch December 22, 2023 10:10
@jack-coggin jack-coggin deleted the one-login branch December 22, 2023 10:11
@jack-coggin jack-coggin restored the one-login branch December 22, 2023 11:04
@jack-coggin jack-coggin deleted the one-login branch December 22, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adr Architectural Design Record deployed Review app deployed for testing documentation Improvements or additions to documentation frontend Changes to assets detected review Review app deployed to Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants