ER-892 Assessment Results Banner styling update #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martikat
changed the title
jack-coggin
approved these changes
Dec 18, 2023
|
👍🏼 |
|
Using an ID on that page is an alternative way to help drill down on the styling. I am not requesting changes but consider it so we can discuss the pros and cons. For example |
|
It all looks ok but before I approve I just want to. check if this is the same component being used here: This is too close the the heading so I was not sure |
instantrick
reviewed
Dec 19, 2023
instantrick
approved these changes
Dec 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jack-coggin
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Update margin bottom for assessment result banner * Update to ensure only assessment banner styling is updated * Update margin bottom for assessment results banner following PR comment * Update to where styling is applied for assessment results banner
martikat
added a commit
that referenced
this pull request
Feb 29, 2024
* wip * wip: Update to add opinion intro and opinion * wip: Update to include other text field * wip: Update for new question response type * wip: add text area feedback question type * wip: Update for end of module feedback journey and feedback intro buttons * wip: Update end of module feedback journey * wip: Update to hide Additional feedback in module overview * wip: Progress bar update to match designs * wip: Update to ensure error handling is shown when no option is selected * wip: Update to include optional show of hint text for feedback questions * wip: update to ensure feedback questions can be used across modules * wip: create feedback forms controller * ER-892 Assessment Results Banner styling update (#1011) * Update margin bottom for assessment result banner * Update to ensure only assessment banner styling is updated * Update margin bottom for assessment results banner following PR comment * Update to where styling is applied for assessment results banner * GovOne authentication integration changes (#1020) * WIP * tweak logout path logic * Existing session logic * Opt in WCAG logic * add check for session id token in logout link * QA debug * Avoid duplicate hits on about page * Sanity check * Fix memory issue for QA locally and in pipeline? * Trigger full WCAG check on demand if already deployed and includes changes * Factory and count * Test feature in pipeline * Integrate GovOne to replace existing sessions and skip deprecated specs * Update docs and fix specs * Increase coverage * Fix pa11y and plan to retire old devise functionality * Tidy * Delete old GPaaS debugging var --------- Co-authored-by: jack.coggin <[email protected]> * Bump rubocop-govuk from 4.12.0 to 4.13.0 (#1025) * Bump rubocop-govuk from 4.12.0 to 4.13.0 Bumps [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) from 4.12.0 to 4.13.0. - [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md) - [Commits](alphagov/rubocop-govuk@v4.12.0...v4.13.0) --- updated-dependencies: - dependency-name: rubocop-govuk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Conform to new style guide --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter David Hamilton <[email protected]> * ER-872 GovOne Banner (#1038) * Add banner regarding change to Gov One authentication * Update link to external content * Quick CMS resource debugger (#1040) * Quick CMS resource debugger * Improve coverage * LINTING!!! * Correct case * ER-899 Local Authority User active user update (#1041) * Update local authority user to not count closed accounts * Update closed trait to inherit from registered * Remove validation skipping for GOV.UK One Login user creation (#1031) * remove validation skipping for one login user creation * rubocop * move random password logic to own method * update t&c logic for one login enabled * rubocop * skip existing sign up spec if gov one login enabled * add one login enabled to check to specs * skip one login user creation in specs if gov one login not enabled * tweak user spec * update sessions controller spec * update user spec * add spec for terms and conditions form * add spec for role type form * update user spec * Exceed coverage threshold * fix locales typo * Improve course engagement test coverage and fix misnamed method --------- Co-authored-by: Peter David Hamilton <[email protected]> * update gov.uk one login integration credentials (#1037) * update gov one integration credentials * Fix domain running in production locally --------- Co-authored-by: Peter David Hamilton <[email protected]> * Always recreate container for background workers (#1045) * CMS powered site-wide config (#1044) * PoC for top-level config object defined in CMS * Course configuration * Spec and CMS migration * Fix invalid JS migration * Correct double escape in validation regexp * Force confirmation when destroying containers. (#1052) Use --yes. * Bump puma from 6.4.0 to 6.4.2 (#1039) Bumps [puma](https://github.com/puma/puma) from 6.4.0 to 6.4.2. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v6.4.0...v6.4.2) --- updated-dependencies: - dependency-name: puma dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump follow-redirects from 1.15.3 to 1.15.4 (#1043) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Er 832 Early years experience (#1048) * remove validation skipping for one login user creation * rubocop * move random password logic to own method * update t&c logic for one login enabled * rubocop * skip existing sign up spec if gov one login enabled * add one login enabled to check to specs * skip one login user creation in specs if gov one login not enabled * tweak user spec * update sessions controller spec * update user spec * add spec for terms and conditions form * add spec for role type form * update user spec * Exceed coverage threshold * fix locales typo * add early years experience registration step * update back links for registration steps * add early years experience to account page * add new registration journey events and update early years experience registration form * update yard annotation in ey experience form * update seeds snippets spec locales count * add tracking to all registration controllers * fix key typo * fix event tracking in registration controllers --------- Co-authored-by: Peter David Hamilton <[email protected]> * Update Local Authority User to count using specific criteria and add new counts to user overview (#1053) * ER-893 Certificate design (#1051) - Adjust the design of the certificate page to include a thumbnail sample. - Adjust the typography of the certificate PDF with conditional styling. - Install additional fonts for use by Puppeteer and Chromium (further work required). * ER-898 CMS model evolution (#1018) * wip * Make assessment threshold value a dev concern and validate new field * Refactor module #card_title to #heading with coverage * Update effected spec * Update release docs and QA password * Post catch-up renaming * Migration correct names * Migration correct names more * Delete stubbed field used during transition * wip: navigate between main feedback form questions * wip * wip: add answer validation * wip: add validation * rubocop * add support for nil user responses * wip: allow user to update previous answers * add introduction and thank you pages * add additional text input for further details * wip * wip: Update to add opinion intro and opinion * wip: Update to include other text field * wip: Update for new question response type * wip: add text area feedback question type * wip: Update for end of module feedback journey and feedback intro buttons * wip: Update end of module feedback journey * wip: Update to hide Additional feedback in module overview * wip: Progress bar update to match designs * wip: Update to ensure error handling is shown when no option is selected * wip: Update to include optional show of hint text for feedback questions * wip: update to ensure feedback questions can be used across modules * wip: Update for responses table and saving text input questions * wip: Update one-off question logic and page count logic in module * wip: Copy across opinion radio button * update migrations * create guest struct * Update logic for link helper and update specs * Update specs and text input logic update in response model * Ensure CMS webhooks continue to work even whilst in maintenance mode (#1103) * fix course spec * Update ci workflow with correct feature flags and update specs --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: jack.coggin <[email protected]> Co-authored-by: Peter Hamilton <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jack-coggin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ER-892