Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ER-856 About Page #1009

Merged
merged 6 commits into from
Dec 20, 2023
Merged

ER-856 About Page #1009

merged 6 commits into from
Dec 20, 2023

Conversation

peterdavidhamilton
Copy link
Contributor

@peterdavidhamilton peterdavidhamilton commented Dec 11, 2023 •
edited
Loading

download

CMS changes required

Edit the about.course resource by moving the heading and first paragraph into two new entries, about.heading and about.hero respectively.

Page routing

Existing page

  • /about-training

New pages

  • /about/module-name
  • /about/the-experts

@peterdavidhamilton peterdavidhamilton added the review Review app deployed to Azure label Dec 11, 2023
@peterdavidhamilton peterdavidhamilton self-assigned this Dec 11, 2023
@github-actions GitHub Actions
Copy link

https://eyrecovery-review-pr-1009.azurewebsites.net

@peterdavidhamilton
- style sidebar links with active page logic
c1310c4 
- refactor SCSS and use media query
- adjust components to match prototype
- add coverage for path, title and layout
- convert static text to CMS resources
@github-actions github-actions bot added the frontend Changes to assets detected label Dec 18, 2023
@peterdavidhamilton peterdavidhamilton added this to the rc0.12.5 milestone Dec 18, 2023
@peterdavidhamilton peterdavidhamilton marked this pull request as ready for review December 18, 2023 13:38
@peterdavidhamilton peterdavidhamilton modified the milestones: rc0.12.5, rc0.13.0 Dec 18, 2023
@instantrick
Copy link

The first two lines on the first page are repeated:
image

@peterdavidhamilton
Copy link
Contributor Author

The first two lines on the first page are repeated: image

This is because the CMS change needs to be made by the content team, however there are already existing edits on that resource. This is on their radar and will be amended prior to release.

@peterdavidhamilton peterdavidhamilton removed their assignment Dec 19, 2023
instantrick
instantrick approved these changes Dec 19, 2023
View reviewed changes
Copy link

@instantrick instantrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

martikat
martikat requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@martikat martikat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed in the Figma and Lucid On completion of this module you will be able to: is bold whereas in the implementation here this is not. Just wanted to check: is this styling correct in this instance?

@peterdavidhamilton
Copy link
Contributor Author

I have noticed in the Figma and Lucid On completion of this module you will be able to: is bold whereas in the implementation here this is not. Just wanted to check: is this styling correct in this instance?

Good spot @martikat. In order to style it correctly it would require further content changes to a TrainingModule field.
We need a second pass at this and to create a new attribute so views/about/show is more easily composed.

Screenshot 2023-12-19 at 16 06 38

@peterdavidhamilton peterdavidhamilton added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit f28c15e Dec 20, 2023
3 checks passed
@peterdavidhamilton peterdavidhamilton deleted the ER-856-about-page branch December 20, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@instantrick instantrick instantrick approved these changes

@martikat martikat martikat approved these changes

Assignees
No one assigned
Labels
frontend Changes to assets detected review Review app deployed to Azure
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@peterdavidhamilton @instantrick @martikat