ER-895 Local Authority User data discrepancy (#1019)

* Update user to show correct number of registered per local authority * Remove confirmed line in spec
DFE-Digital · Dec 21, 2023 · 399f3fa · 399f3fa
1 parent 4303347
commit 399f3fa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/models/data_analysis/local_authority_user.rb b/app/models/data_analysis/local_authority_user.rb
@@ -30,7 +30,7 @@ def authorities
 
       # @return [User::ActiveRecord_Relation]
       def public_beta_users
-        User.since_public_beta.with_local_authority
+        User.since_public_beta.with_local_authority.registration_complete
       end
     end
   end

diff --git a/spec/models/data_analysis/local_authority_user_spec.rb b/spec/models/data_analysis/local_authority_user_spec.rb
@@ -22,6 +22,10 @@
   end
 
   before do
+    # Incomplete registration
+    create :user, :named, local_authority: 'LA3'
+
+    # Registered user
     create :user, :registered, local_authority: 'LA1'
     create :user, :registered, local_authority: 'LA1'
     create :user, :registered, local_authority: 'LA3'