add started guard clause to new tag

DFE-Digital · Dec 1, 2023 · 01f8d17 · 01f8d17
1 parent 5e3c7c7
commit 01f8d17
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss
@@ -191,10 +191,10 @@ ul>li>ul>li {
   display: none;
 }
 
-.section-tag {
-  margin-left: govuk-spacing(1);
-}
-
 .white-space-pre-wrap {
   white-space: pre-wrap;
 }
+
+#available .govuk-tag {
+  margin-left: govuk-spacing(1);
+}
diff --git a/app/services/visit_changes.rb b/app/services/visit_changes.rb
@@ -14,6 +14,8 @@ def new_modules?
   # @param mod [Training::Module]
   # @return [Boolean]
   def new_module?(mod)
+    return false if user.course.started?(mod)
+
     previous_visit && previous_visit.started_at.to_i < mod.first_published_at.to_i
   end
 

diff --git a/app/views/learning/_card.html.slim b/app/views/learning/_card.html.slim
@@ -4,7 +4,7 @@
 
     - if current_user.visit_changes.new_module?(mod)
       span.govuk-tag.govuk-tag--ey
-        = t('my_learning.new.card_tag')
+        = t('my_learning.new_tag.card')
 
     h3.govuk-heading-s
       = govuk_link_to mod.card_title, training_module_path(mod.name), no_visited_state: true, class: 'card-link--header'

diff --git a/app/views/learning/show.html.slim b/app/views/learning/show.html.slim
@@ -31,7 +31,7 @@
         | Available modules
         - if current_user.visit_changes.new_modules?
           span.govuk-tag.section-tag
-            = t('my_learning.new.section_tag')
+            = t('my_learning.new_tag.section')
       - if current_user.course.available_modules.any?
         .grid-container
           - current_user.course.available_modules.each do |mod|

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -276,9 +276,9 @@ en:
       percentage: "Your progress: %{num}"
       viewed: You have read %{num} pages
       remaining: Only %{num} pages remaining
-    new:
-      card_tag: NEW
-      section_tag: NEW MODULE AVAILABLE
+    new_tag:
+      card: NEW
+      section: NEW MODULE AVAILABLE
 
   my_learning_log:
     title: Learning log