changes in validation in additional contacts

DFE-Digital · Sep 17, 2024 · 9e41542 · 9e41542
1 parent 6317b8d
commit 9e41542
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/app/controllers/support/cases/additional_contacts_controller.rb b/app/controllers/support/cases/additional_contacts_controller.rb
@@ -14,7 +14,6 @@ def new
     def create
       @case_additional_contact_form = CaseAdditionalContactForm.from_validation(validation)
       @current_case = Support::Case.find(case_additional_contact_form_params[:support_case_id]) if @current_case.blank?
-      @emails = @current_case.case_additional_contacts&.pluck(:email)
       if validation.success? && !@emails.include?(case_additional_contact_form_params[:email])
         Support::CaseAdditionalContact.create!(case_additional_contact_form_params)
         redirect_to support_case_additional_contacts_path(case_id: @current_case.id), notice: I18n.t("support.case_contact_details.flash.success")

diff --git a/app/forms/support/case_additional_contact_form_schema.rb b/app/forms/support/case_additional_contact_form_schema.rb
@@ -3,8 +3,8 @@ class CaseAdditionalContactFormSchema < Dry::Validation::Contract
     include Concerns::TranslatableFormSchema
 
     params do
-      required(:first_name).value(:string)
-      required(:last_name).value(:string)
+      optional(:first_name).value(:string)
+      optional(:last_name).value(:string)
       optional(:phone_number).value(:string)
       required(:email).value(:string)
       optional(:extension_number).value(:string)

diff --git a/app/models/support/case_additional_contact.rb b/app/models/support/case_additional_contact.rb
@@ -3,7 +3,7 @@ class CaseAdditionalContact < ApplicationRecord
     belongs_to :case, class_name: "Support::Case", foreign_key: "support_case_id"
     belongs_to :organisation, class_name: "Support::Organisation", optional: true
 
-    validates :first_name, :last_name, :email, presence: true
+    validates :email, presence: true
 
     def self.role_values
       %w[lead evaluator]