[176] Bug fix: Additional filter to remove duplicate rows on performance reports

[elceebee]

Context

A bug was noticed last year that some provider performance reports have duplicate rows. We've confirmed with the data insights team that this is because the SQL required an additional WHERE filter.

This only matters to provider reports -- the additional clause already existed in the national reports.

Changes proposed in this pull request

• Additional WHERE clause. teach_first_or_iot_filter: 'All', on the BigQuery query for provider reports.

Guidance to review

We'll test it in production as we are unable to use BigQuery locally / qa / staging / review apps.

Things to check

• If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
• This code does not rely on migrations in the same Pull Request
• If this code includes a migration adding or changing columns, it also backfills existing records for consistency
• If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
• If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
• API release notes have been updated if necessary
• If it adds a significant user-facing change, is it documented in the CHANGELOG?
• Attach the PR to the Trello card

[elceebee]

Bug: Duplicate rows of subjects in "Weekly recruitment performance report"

[github-actions]

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/provider_interface/candidate_pool/provider_views_candidate_pool_list_spec.rb:15: ⚠️ Expected �[33m["M***** A*****", "B***** C*****"]�[0m to eq �[35m["B***** C*****", "M***** A*****"]�[0m.

�[37mDiff:�[0m

�[34m┌ (Key) ──────────────────────────┐�[0m
�[34m│ �[0m�[35m‹-› in expected, not in actual�[0m�[34m │�[0m
�[34m│ �[0m�[33m‹+› in actual, not in expected�[0m�[34m │�[0m
�[34m│ �[0m‹ › in both expected and actual�[34m │�[0m
�[34m└─────────────────────────────────┘�[0m

[
�[35m- "B***** C*****",�[0m
"M***** A*****",
�[33m+ "B***** C*****"�[0m
]

[dcyoung-dev]

😬