Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[625] Part 2, Ingest new visa sponsorship field #10466

Merged

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Mar 6, 2025

Context

This is the second PR for this ticket. See the first PR for a detailed description

Changes proposed in this pull request

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee force-pushed the 625-ingest-new-visa-sponsorship-attribute-into-apply-apply branch from 8530fda to 200bd89 Compare March 6, 2025 15:15
Base automatically changed from 625-ingest-new-visa-sponsorship-attribute-into-apply-apply to main March 6, 2025 15:51
@elceebee elceebee force-pushed the 625-part-2-ingest-new-visa-sponsorship-attribute-into-apply branch from c58bd25 to eab0c09 Compare March 6, 2025 15:51
@elceebee elceebee changed the title Ingest new visa sponsorship field [625] Part 2, Ingest new visa sponsorship field Mar 6, 2025
@elceebee
Copy link
Contributor Author

elceebee commented Mar 6, 2025

@elceebee elceebee self-assigned this Mar 6, 2025
@elceebee elceebee marked this pull request as ready for review March 6, 2025 15:59
@elceebee elceebee force-pushed the 625-part-2-ingest-new-visa-sponsorship-attribute-into-apply branch from eab0c09 to a3970eb Compare March 6, 2025 16:02
Copy link
Contributor

github-actions bot commented Mar 6, 2025

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/provider_interface/candidate_pool/provider_views_candidate_pool_list_spec.rb:15: ⚠️ Expected �[33m["G***** V*****", "T***** B*****"]�[0m to eq �[35m["T***** B*****", "G***** V*****"]�[0m.

�[37mDiff:�[0m

�[34m┌ (Key) ──────────────────────────┐�[0m
�[34m│ �[0m�[35m‹-› in expected, not in actual�[0m�[34m │�[0m
�[34m│ �[0m�[33m‹+› in actual, not in expected�[0m�[34m │�[0m
�[34m│ �[0m‹ › in both expected and actual�[34m │�[0m
�[34m└─────────────────────────────────┘�[0m

[
�[35m- "T***** B*****",�[0m
"G***** V*****",
�[33m+ "T***** B*****"�[0m
]

@elceebee elceebee merged commit 33c218f into main Mar 6, 2025
24 of 25 checks passed
@elceebee elceebee deleted the 625-part-2-ingest-new-visa-sponsorship-attribute-into-apply branch March 6, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants