-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data migrations for adding recruitment cycles to database #10320
Merged
elceebee
merged 1 commit into
main
from
266-part-2-data-migration-for-recruitment-cycle-timetables
Jan 31, 2025
Merged
Data migrations for adding recruitment cycles to database #10320
elceebee
merged 1 commit into
main
from
266-part-2-data-migration-for-recruitment-cycle-timetables
Jan 31, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ef4611c
to
a680cb8
Compare
11d8bb2
to
c376f03
Compare
dcyoung-dev
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change suggested
app/services/data_migrations/add_all_recruitment_cycle_timetables_to_database.rb
Outdated
Show resolved
Hide resolved
3ce8e62
to
6328bb0
Compare
c376f03
to
f4274a6
Compare
dd6313d
to
cecdeb7
Compare
Base automatically changed from
266-part-1-recruitment-cycle-timetables-models-and-migrations
to
main
January 30, 2025 17:11
9076e04
to
1e4868f
Compare
1e4868f
to
4a4fcfa
Compare
dcyoung-dev
approved these changes
Jan 31, 2025
app/services/data_migrations/add_all_recruitment_cycle_timetables_to_database.rb
Outdated
Show resolved
Hide resolved
4a4fcfa
to
fc5fdae
Compare
fc5fdae
to
52b3034
Compare
52b3034
to
bf25ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR follow on from this one. See that description for full context.
Changes proposed in this pull request
We add the dates to the database. Future PRs will use the dates.
Guidance to review
Things to check