Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data migrations for adding recruitment cycles to database #10320

Merged

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Jan 29, 2025

Context

This PR follow on from this one. See that description for full context.

Changes proposed in this pull request

We add the dates to the database. Future PRs will use the dates.

  • Using the database backed timetables for end of cycle related jobs
  • Using the db backed timetables for UI conditions
  • Using the db backed timetables for Cycle Switching (Ideally this will include an API end point for syncing with production)

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee self-assigned this Jan 29, 2025
@elceebee elceebee force-pushed the 266-part-1-recruitment-cycle-timetables-models-and-migrations branch from ef4611c to a680cb8 Compare January 30, 2025 09:43
@elceebee elceebee force-pushed the 266-part-2-data-migration-for-recruitment-cycle-timetables branch from 11d8bb2 to c376f03 Compare January 30, 2025 09:44
@dcyoung-dev dcyoung-dev marked this pull request as ready for review January 30, 2025 10:15
@dcyoung-dev dcyoung-dev marked this pull request as draft January 30, 2025 10:16
Copy link
Collaborator

@dcyoung-dev dcyoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change suggested

@elceebee elceebee force-pushed the 266-part-1-recruitment-cycle-timetables-models-and-migrations branch 2 times, most recently from 3ce8e62 to 6328bb0 Compare January 30, 2025 14:01
@elceebee elceebee force-pushed the 266-part-2-data-migration-for-recruitment-cycle-timetables branch from c376f03 to f4274a6 Compare January 30, 2025 14:09
@elceebee elceebee force-pushed the 266-part-1-recruitment-cycle-timetables-models-and-migrations branch 2 times, most recently from dd6313d to cecdeb7 Compare January 30, 2025 16:36
Base automatically changed from 266-part-1-recruitment-cycle-timetables-models-and-migrations to main January 30, 2025 17:11
@elceebee elceebee force-pushed the 266-part-2-data-migration-for-recruitment-cycle-timetables branch from 9076e04 to 1e4868f Compare January 31, 2025 09:15
@elceebee elceebee force-pushed the 266-part-2-data-migration-for-recruitment-cycle-timetables branch from 1e4868f to 4a4fcfa Compare January 31, 2025 09:24
@elceebee
Copy link
Contributor Author

@elceebee elceebee marked this pull request as ready for review January 31, 2025 09:48
@elceebee elceebee force-pushed the 266-part-2-data-migration-for-recruitment-cycle-timetables branch from 4a4fcfa to fc5fdae Compare January 31, 2025 11:22
@elceebee elceebee force-pushed the 266-part-2-data-migration-for-recruitment-cycle-timetables branch from fc5fdae to 52b3034 Compare January 31, 2025 11:23
@elceebee elceebee force-pushed the 266-part-2-data-migration-for-recruitment-cycle-timetables branch from 52b3034 to bf25ed6 Compare January 31, 2025 13:49
@elceebee elceebee merged commit a0b586a into main Jan 31, 2025
24 checks passed
@elceebee elceebee deleted the 266-part-2-data-migration-for-recruitment-cycle-timetables branch January 31, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants