[SVR-50] 트랜젝션 처리 추 (#63)

DCNJ-Uket · Oct 26, 2024 · dc1d0df · dc1d0df
1 parent dcd8c89
commit dc1d0df
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 14 deletions.
diff --git a/.../admin-app-api/src/main/java/com/uket/app/admin/api/controller/impl/TicketController.java b/.../admin-app-api/src/main/java/com/uket/app/admin/api/controller/impl/TicketController.java
@@ -15,7 +15,6 @@
 import com.uket.app.admin.api.service.LiveEnterUserDto;
 import com.uket.app.admin.api.service.TicketAdminService;
 import com.uket.core.exception.ErrorCode;
-import com.uket.domain.ticket.dto.CheckTicketDto;
 import com.uket.domain.ticket.dto.TicketDto;
 import com.uket.domain.ticket.entity.Ticket;
 import com.uket.domain.ticket.enums.TicketStatus;

diff --git a/...pp-api/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByCreatedAt.java b/...pp-api/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByCreatedAt.java
@@ -2,21 +2,17 @@
 
 import com.uket.app.admin.api.dto.request.SearchRequest;
 import com.uket.app.admin.api.enums.TicketSearchType;
-import com.uket.core.exception.ErrorCode;
 import com.uket.domain.ticket.dto.CheckTicketDto;
 import com.uket.domain.ticket.entity.Ticket;
-import com.uket.domain.ticket.exception.TicketException;
 import com.uket.domain.ticket.repository.TicketRepository;
 import java.sql.Timestamp;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.time.LocalTime;
-import java.time.format.DateTimeFormatter;
-import java.time.format.DateTimeParseException;
-import lombok.RequiredArgsConstructor;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 @Service
 public class TicketSearcherByCreatedAt extends TicketSearcher{
@@ -31,6 +27,7 @@ public Boolean isSupport(TicketSearchType searchType) {
     }
 
     @Override
+    @Transactional(readOnly = true)
     public Page<CheckTicketDto> search(SearchRequest searchRequest, Pageable pageable) {
         LocalDate createdAtLocal = searchRequest.createdAt();
         if(createdAtLocal == null){

diff --git a/...p-api/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByModifiedAt.java b/...p-api/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByModifiedAt.java
@@ -9,10 +9,10 @@
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.time.LocalTime;
-import lombok.RequiredArgsConstructor;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 @Service
 public class TicketSearcherByModifiedAt extends TicketSearcher{
@@ -27,9 +27,10 @@ public Boolean isSupport(TicketSearchType searchType) {
     }
 
     @Override
+    @Transactional(readOnly = true)
     public Page<CheckTicketDto> search(SearchRequest searchRequest, Pageable pageable) {
         LocalDate modifiedAtLocal = searchRequest.modifiedAt();
-        if(modifiedAtLocal == null){
+        if(modifiedAtLocal == null) {
             throw new IllegalStateException("createdAt이 null일 수 없습니다.");
         }
         LocalDateTime modifyStart = modifiedAtLocal.atStartOfDay();
@@ -38,6 +39,7 @@ public Page<CheckTicketDto> search(SearchRequest searchRequest, Pageable pageabl
         Timestamp modifyEndTimestamp = Timestamp.valueOf(modifyEnd);
 
         Page<Ticket> tickets = ticketRepository.findByModifiedAtBetween(modifyStartTimestamp, modifyEndTimestamp,pageable);
+
         return tickets.map(CheckTicketDto::from);
     }
 }
diff --git a/...-api/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByPhoneNumber.java b/...-api/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByPhoneNumber.java
@@ -7,6 +7,7 @@
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 
 @Service
@@ -22,6 +23,7 @@ public Boolean isSupport(TicketSearchType searchType) {
     }
 
     @Override
+    @Transactional(readOnly = true)
     public Page<CheckTicketDto> search(SearchRequest searchRequest, Pageable pageable) {
         return ticketRepository.findByUserUserDetailsPhoneNumber(searchRequest.phoneNumber(), pageable);
     }

diff --git a/.../main/java/com/uket/app/admin/api/service/search/TicketSearcherByReservationUserType.java b/.../main/java/com/uket/app/admin/api/service/search/TicketSearcherByReservationUserType.java
@@ -5,10 +5,10 @@
 import com.uket.domain.ticket.dto.CheckTicketDto;
 import com.uket.domain.ticket.entity.Ticket;
 import com.uket.domain.ticket.repository.TicketRepository;
-import lombok.RequiredArgsConstructor;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 @Service
 public class TicketSearcherByReservationUserType extends TicketSearcher{
@@ -23,6 +23,7 @@ public Boolean isSupport(TicketSearchType searchType) {
     }
 
     @Override
+    @Transactional(readOnly = true)
     public Page<CheckTicketDto> search(SearchRequest searchRequest, Pageable pageable) {
         Page<Ticket> tickets = ticketRepository.findByReservationType(searchRequest.reservationUserType(), pageable);
         return tickets.map(CheckTicketDto::from);

diff --git a/...pi/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByShowStartDate.java b/...pi/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByShowStartDate.java
@@ -2,20 +2,16 @@
 
 import com.uket.app.admin.api.dto.request.SearchRequest;
 import com.uket.app.admin.api.enums.TicketSearchType;
-import com.uket.core.exception.ErrorCode;
 import com.uket.domain.ticket.dto.CheckTicketDto;
 import com.uket.domain.ticket.entity.Ticket;
-import com.uket.domain.ticket.exception.TicketException;
 import com.uket.domain.ticket.repository.TicketRepository;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.time.LocalTime;
-import java.time.format.DateTimeFormatter;
-import java.time.format.DateTimeParseException;
-import lombok.RequiredArgsConstructor;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 @Service
 public class TicketSearcherByShowStartDate extends TicketSearcher{
@@ -30,6 +26,7 @@ public Boolean isSupport(TicketSearchType searchType) {
     }
 
     @Override
+    @Transactional(readOnly = true)
     public Page<CheckTicketDto> search(SearchRequest searchRequest, Pageable pageable) {
         LocalDate showDateLocal = searchRequest.showDate();
         if(showDateLocal == null){

diff --git a/...n-app-api/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByStatus.java b/...n-app-api/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByStatus.java
@@ -8,6 +8,7 @@
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 @Service
 public class TicketSearcherByStatus extends TicketSearcher{
@@ -22,6 +23,7 @@ public Boolean isSupport(TicketSearchType searchType) {
     }
 
     @Override
+    @Transactional(readOnly = true)
     public Page<CheckTicketDto> search(SearchRequest searchRequest, Pageable pageable) {
         Page<Ticket> tickets = ticketRepository.findByStatus(searchRequest.status(), pageable);
         return tickets.map(CheckTicketDto::from);

diff --git a/...app-api/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByUserName.java b/...app-api/src/main/java/com/uket/app/admin/api/service/search/TicketSearcherByUserName.java
@@ -8,6 +8,7 @@
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 @Service
 public class TicketSearcherByUserName extends TicketSearcher{
@@ -22,6 +23,7 @@ public Boolean isSupport(TicketSearchType searchType) {
     }
 
     @Override
+    @Transactional(readOnly = true)
     public Page<CheckTicketDto> search(SearchRequest searchRequest, Pageable pageable) {
         Page<Ticket> tickets = ticketRepository.findByUserName(searchRequest.userName(), pageable);
         return tickets.map(CheckTicketDto::from);