Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 190 pickable configs #243

Merged

Conversation

maxschloegel
Copy link
Contributor

MR to test whether rtdc_dataset.config.Configuration is pickable.
Close #190

Copy link
Member

@paulmueller paulmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ee2099) 91.24% compared to head (107b4c7) 71.73%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #243       +/-   ##
===========================================
- Coverage   91.24%   71.73%   -19.52%     
===========================================
  Files         110      110               
  Lines        7793     7793               
===========================================
- Hits         7111     5590     -1521     
- Misses        682     2203     +1521     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulmueller
Copy link
Member

rtd build failure is unrelated to this PR

@paulmueller paulmueller merged commit c09d74a into DC-analysis:master Nov 28, 2023
15 checks passed
@maxschloegel maxschloegel deleted the issue_190_pickable_configs branch November 28, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make rtdc_dataset.config.Configuration pickable
3 participants