refs LibraryOfCongress#119 - fixed different case issue and added tes…

…t to check for any issues in the future

src/main/java/gov/loc/repository/bagit/conformance/ManifestChecker.java

@@ -123,9 +123,10 @@ private static void checkManifestPayload(final Path manifestFile, final Charset
         String path = parsePath(line);
 
         path = checkForManifestCreatedWithMD5SumTools(path, warnings, warningsToIgnore);
-        paths.add(path.toLowerCase());
 
         checkForDifferentCase(path, paths, manifestFile, warnings, warningsToIgnore);
+        paths.add(path.toLowerCase());
+
         if(encoding.name().startsWith("UTF")){
           checkNormalization(path, manifestFile.getParent(), warnings, warningsToIgnore);
         }
@@ -256,7 +257,7 @@ static void checkAlgorthm(final String algorithm, final Set<BagitWarning> warnin
       warnings.add(BagitWarning.WEAK_CHECKSUM_ALGORITHM);
     }
 
-    else if(!warningsToIgnore.contains(BagitWarning.NON_STANDARD_ALGORITHM) && !"SHA-512".equals(upperCaseAlg)){
+    else if(!warningsToIgnore.contains(BagitWarning.NON_STANDARD_ALGORITHM) && !"SHA512".equals(upperCaseAlg)){
       logger.warn(messages.getString("non_standard_algorithm_warning"), algorithm);
       warnings.add(BagitWarning.NON_STANDARD_ALGORITHM);
     }

src/main/java/gov/loc/repository/bagit/hash/StandardSupportedAlgorithms.java

@@ -6,9 +6,9 @@
 public enum StandardSupportedAlgorithms implements SupportedAlgorithm{
   MD5("MD5"),
   SHA1("SHA-1"),
-  SHA224("SHA-224"),
-  SHA256("SHA-256"),
-  SHA512("SHA-512");
+  SHA224("SHA224"),
+  SHA256("SHA256"),
+  SHA512("SHA512");
 
   private final String messageDigestName;
 

src/test/java/gov/loc/repository/bagit/conformance/BagLinterTest.java

@@ -28,6 +28,13 @@ public void testClassIsWellDefined() throws NoSuchMethodException, InvocationTar
     assertUtilityClassWellDefined(BagLinter.class);
   }
 
+  @Test
+  public void testConformantBag() throws Exception{
+	  Path goodBag = Paths.get("src", "test", "resources", "bags", "v1_0", "bag");
+	  Set<BagitWarning> warnings = BagLinter.lintBag(goodBag);
+	  Assertions.assertTrue(warnings.size() == 0);
+  }
+
   @Test
   public void testLintBag() throws Exception{
     Set<BagitWarning> expectedWarnings = new HashSet<>();

src/test/resources/bags/v1_0/bag/bag-info.txt

@@ -0,0 +1,3 @@
+Bag-Software-Agent: bagit.py v1.7.0 <https://github.com/LibraryOfCongress/bagit-python>
+Bagging-Date: 2018-07-22
+Payload-Oxum: 6.1

src/test/resources/bags/v1_0/bag/bagit.txt

@@ -0,0 +1,2 @@
+BagIt-Version: 1.0
+Tag-File-Character-Encoding: UTF-8

src/test/resources/bags/v1_0/bag/data/foo.txt

@@ -0,0 +1 @@
+hello

src/test/resources/bags/v1_0/bag/manifest-sha512.txt

@@ -0,0 +1 @@
+e7c22b994c59d9cf2b48e549b1e24666636045930d3da7c1acb299d1c3b7f931f94aae41edda2c2b207a36e10f8bcb8d45223e54878f5b316e7ce3b6bc019629  data/foo.txt

src/test/resources/bags/v1_0/bag/tagmanifest-sha512.txt

@@ -0,0 +1,3 @@
+f5bdbc7f273dd8b95d30b77b3d6f727d999ecbe9be06a7656388e7a3a46d963881563d779a2a99265b0c2785de2a7b72ac05fa7bc5b66b471d3f4e80fe9bb370 bag-info.txt
+1d73ae108d4109b61f56698a5e19ee1f8947bdf8940bbce6adbe5e0940c2363caace6a547b4f1b3ec6a4fd2b7fa845e9cb9d28823bc72c59971718bb26f2fbd8 bagit.txt
+35d40e38f5e2eb7261a1cc0c0ccf9c6c50d2e07e39a9460ec4f99046048f939d82647c68d8f744c653c7a37c05cc9d71153c8028786dfeba4322a3be5fe81af0 manifest-sha512.txt