Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the UI for graph #60

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Improves the UI for graph #60

merged 4 commits into from
Mar 7, 2024

Conversation

elijahbenizzy
Copy link
Contributor

@elijahbenizzy elijahbenizzy commented Mar 6, 2024

  • only one node is colored
  • The others are higlighted
  • Edge paths are highlighted too

Ellipsis 🚀 This PR description was created by Ellipsis for commit b33d95c.

Summary:

This PR updates the graph UI by enhancing node and edge highlighting, incorporating edge data into the graph layout, and making updates to several files.

Key points:

  • Updated node and edge highlighting in the graph UI
  • Included edge data in the graph layout
  • Made changes to AppView.tsx and GraphView.tsx
  • Renamed hoverIndex state to hoverSequenceID in AppView.tsx
  • Introduced EdgeData type in GraphView.tsx
  • Updated getLayoutedElements and convertApplicationToGraph functions in GraphView.tsx to include edge data
  • Made minor changes to layout.tsx and table.tsx files in telemetry/ui/src/components/common directory

Generated with ❤️ by ellipsis.dev

- only one node is colored
- The others are higlighted
- Edge paths are highlighted too
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested.

  • Reviewed the entire pull request up to 940bc64
  • Looked at 251 lines of code in 2 files
  • Took 2 minutes and 8 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 0 additional comments because they didn't meet confidence threshold of 50%.

Workflow ID: wflow_jixzOIyMuHRqkSEf


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

telemetry/ui/src/components/routes/app/GraphView.tsx Outdated Show resolved Hide resolved
telemetry/ui/src/components/routes/app/AppView.tsx Outdated Show resolved Hide resolved
@elijahbenizzy elijahbenizzy requested a review from skrawcz March 6, 2024 19:58
@DAGWorks-Inc DAGWorks-Inc deleted a comment from ellipsis-dev bot Mar 6, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Performed an incremental review on 2058b94
  • Looked at 68 lines of code in 3 files
  • Took 2 minutes and 16 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 2 additional comments because they didn't meet confidence threshold of 50%.
1. telemetry/ui/src/components/routes/app/GraphView.tsx:122:
  • Assessed confidence : 0%
  • Comment:
    Good job on removing the console.log statements. It makes the code cleaner and removes unnecessary console output.
  • Reasoning:
    The PR author has removed some console.log statements which were probably used for debugging. This is a good practice as it cleans up the code and removes unnecessary console output.
2. telemetry/ui/src/components/routes/app/AppView.tsx:207:
  • Assessed confidence : 0%
  • Comment:
    Good job on replacing '==' with '==='. This prevents unexpected behavior by also checking the type of the operands.
  • Reasoning:
    The PR author has replaced the '==' operator with '===' in a comparison. This is a good practice as '===' also checks the type of the operands, which can prevent unexpected behavior.

Workflow ID: wflow_eDacxfmOjqzFdF1T


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

@elijahbenizzy elijahbenizzy force-pushed the minor-ui-improvements branch from 2058b94 to 21283ca Compare March 6, 2024 20:07
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Performed an incremental review on 21283ca
  • Looked at 71 lines of code in 2 files
  • Took 2 minutes and 7 seconds to review
More info
  • Skipped 1 files when reviewing.
  • Skipped posting 2 additional comments because they didn't meet confidence threshold of 50%.
1. telemetry/ui/src/components/common/layout.tsx:16:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    Consider using '===' for comparison to avoid unexpected type coercion. The '===' operator checks both value and type, which is considered more correct.
if (mode === 'first-minimal') {
  • Reasoning:
    The comparison operator '==' is used in the code. It's a good practice to use '===' instead of '==' for comparison to avoid unexpected type coercion. The '===' operator checks both value and type, which is considered more correct.
2. telemetry/ui/src/components/common/table.tsx:132:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    Consider using '===' for comparison to avoid unexpected type coercion. The '===' operator checks both value and type, which is considered more correct.
dense === 0 ? 'py-4' : dense === 1 ? 'py-2.5' : 'py-0.2',
  • Reasoning:
    The comparison operator '==' is used in the code. It's a good practice to use '===' instead of '==' for comparison to avoid unexpected type coercion. The '===' operator checks both value and type, which is considered more correct.

Workflow ID: wflow_HRCMFLFYBmg8UCvf


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

@elijahbenizzy elijahbenizzy force-pushed the minor-ui-improvements branch from 21283ca to b33d95c Compare March 6, 2024 20:10
Nothing in the python version but this has some UI updates that'll be
released shortly, and they're packaged up on pypi as well.
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Performed an incremental review on b33d95c
  • Looked at 71 lines of code in 2 files
  • Took 2 minutes and 42 seconds to review
More info
  • Skipped 1 files when reviewing.
  • Skipped posting 2 additional comments because they didn't meet confidence threshold of 50%.
1. telemetry/ui/src/components/common/layout.tsx:16:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    Consider using '===' for comparison to avoid unexpected type coercion. The '===' operator checks both value and type, which is considered more correct.
if (mode === 'first-minimal') {
  • Reasoning:
    The comparison operator '==' is used in the code. It's a good practice to use '===' instead of '==' for comparison to avoid unexpected type coercion. The '===' operator checks both value and type, which is considered more correct.
2. telemetry/ui/src/components/common/table.tsx:132:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    Consider using '===' for comparison to avoid unexpected type coercion. The '===' operator checks both value and type, which is considered more correct.
dense === 0 ? 'py-4' : dense === 1 ? 'py-2.5' : 'py-0.2',
  • Reasoning:
    The comparison operator '==' is used in the code. It's a good practice to use '===' instead of '==' for comparison to avoid unexpected type coercion. The '===' operator checks both value and type, which is considered more correct.

Workflow ID: wflow_sIvQw0QfXVx6j5SC


Not what you expected? You can customize the content of the reviews using rules. Learn more here.

Copy link

ellipsis-dev bot commented Mar 6, 2024

Skipped PR review on c27e2ee because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.


Generated with ❤️ by ellipsis.dev

@elijahbenizzy
Copy link
Contributor Author

New UI is a little less distracting:
image

@elijahbenizzy elijahbenizzy merged commit ff5c4b4 into main Mar 7, 2024
6 checks passed
@elijahbenizzy elijahbenizzy deleted the minor-ui-improvements branch March 7, 2024 05:09
Copy link

ellipsis-dev bot commented Mar 7, 2024

Skipped PR review on ff5c4b4 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.


Generated with ❤️ by ellipsis.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants