Skip to content

Commit

Permalink
Fixes sequence ID ordering issue
Browse files Browse the repository at this point in the history
We should have been sorting by sequence ID for the step list first, not
time. See #254.
  • Loading branch information
elijahbenizzy committed Jun 25, 2024
1 parent eea14bb commit e3c4e32
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions telemetry/ui/src/components/routes/app/AppView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,11 @@ export const AppView = (props: {
const stepsCopied = [...data.steps];
const stepsSorted = stepsCopied.sort((a, b) => {
// Parse dates to get time in milliseconds
const sequenceA = a.step_start_log.sequence_id;
const sequenceB = b.step_start_log.sequence_id;
if (sequenceA !== sequenceB) {
return sequenceB - sequenceA;
}
const timeA = new Date(a.step_start_log.start_time).getTime();
const timeB = new Date(b.step_start_log.start_time).getTime();

Expand Down

0 comments on commit e3c4e32

Please sign in to comment.