Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove makefile #153

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Remove makefile #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a9255b
remove makefile and update readme/workflows
Cyberbeni Oct 15, 2024
86d37e4
Switch to newer yarn
Cyberbeni Oct 15, 2024
9869df2
revert to yarn v1, update readme
Cyberbeni Oct 15, 2024
be7b92c
yarn upgrade --latest
Cyberbeni Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Update dependencies
run: yarn upgrade --latest
- name: Build
run: make
run: npm run build
- name: Detect changes in distributed code
if: ${{ github.event.inputs.force != 'true' }}
id: changes
Expand Down
16 changes: 0 additions & 16 deletions Makefile
View file
Open in desktop

This file was deleted.

16 changes: 10 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,21 @@ jobs:

## How to contribute

Install npm and yarn on macOS (Homebrew required)
Install Node.js: https://nodejs.org/en/download/package-manager

Install yarn and download the dependencies
```bash
make once-mac
npm install --global yarn
yarn
```

Run before commit
Run before commit (fix any issues manually that formatting can't automatically fix)
```bash
make
npm run format
npm run build
```

Run tests in `./__test__/` (for testing parts of the logic, the real tests are run on GitHub after push/pull request)
Run unit tests in `./tests` (the e2e tests are run on GitHub after push/pull request)
```bash
make test
npm run test
```
6 changes: 3 additions & 3 deletions dist/index.js
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 5 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,24 @@
"license": "MIT",
"dependencies": {
"@actions/cache": "^3.2.4",
"@actions/core": "^1.10.1",
"@actions/core": "^1.11.1",
"@actions/exec": "^1.1.1",
"os": "^0.1.2",
"semver": "^7.6.3",
"uuid": "^10.0.0"
},
"devDependencies": {
"@eslint/js": "^9.11.1",
"@eslint/js": "^9.12.0",
"@stylistic/eslint-plugin": "^2.9.0",
"@tsconfig/node20": "^20.1.4",
"@types/jest": "^29.5.13",
"@types/node": "^22.7.4",
"@types/node": "^22.7.5",
"@types/semver": "^7.5.8",
"@types/uuid": "^10.0.0",
"@vercel/ncc": "^0.38.2",
"eslint": "^9.11.1",
"eslint": "^9.12.0",
"jest": "^29.7.0",
"ts-jest": "^29.2.5",
"typescript": "^5.6.2",
"typescript": "^5.6.3",
"typescript-eslint": "^8.8.1"
}
}
Loading