Add option to fetch Minecraft protocol versions from remote API #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@babel/preset-env now contains @babel/plugin-proposal-class-properties with the default config (which is what parcel uses by default). This removes the redundant .babelrc, which caused a double-declaration error.
|
Would you like me to start reviewing this now or wait until the draft status is removed? |
|
I would wait until I remove the WIP status. As it stands, this is more of a PoC. I'm pretty busy right now, so I don't have much time to work on this 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently released https://github.com/hugmanrique/mc-versions, a project which reports Minecraft version data and is updated daily. It's not a real API per-se since the URL points to a static GitHub asset, but this guarantees the API will be online for long. This PR adds an option to specify the type of version provider (
localormc-versions) and an update interval for fetching versions (both local and remote).(one of the reasons I made it was to stop needing someone to PR an update for each new MC version 😛)
The data fetching and normalization is already done. The versions take a while to be displayed on the client since the API reports so many protocol numbers, and Minetrack needs to ping servers with these versions. However, I've modified
getNextProtocolVersionto skip versions with the same protocol number. The plan is to include aisReleaseflag to skip loading (and therefore pinging with) snapshot/pre-release protocol numbers.