Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump controller-gen to v0.17.0 #4064

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Bump controller-gen to v0.17.0 #4064

wants to merge 2 commits into from

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Jan 3, 2025

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Other

cbandy added 2 commits January 3, 2025 13:50
@cbandy
Bump controller-gen to v0.17.0
4d73723
@cbandy
Change PostgresIdentifier to a type alias
79ea670 
The type existed to avoid schema repetition with controller-gen, but
recent versions can do that using aliases. This eliminates the need for
some conversions.
@cbandy
Copy link
Member Author

cbandy commented Jan 3, 2025

🤦🏻 I only ran generate-crd locally; generate-deepcopy is hitting kubernetes-sigs/controller-tools#813.

@cbandy cbandy marked this pull request as draft January 3, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cbandy