CASMCMS-9273: Improve Python type annotations in boot_set controller submodule #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
requested review from
jsl-hpe,
jsollom-hpe,
rbak-hpe and
kumarrahul04
jsollom-hpe
approved these changes
Feb 6, 2025
mharding-hpe
force-pushed
the
casmcms-9272
branch
from
33a5669 to
24cadd3
Compare
mharding-hpe
force-pushed
the
casmcms-9273
branch
from
bb6cb2e to
2eb2eeb
Compare
mharding-hpe
force-pushed
the
casmcms-9272
branch
from
24cadd3 to
6e9f6f8
Compare
mharding-hpe
force-pushed
the
casmcms-9273
branch
from
2eb2eeb to
ba02184
Compare
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the type annotation work started in the following PRs:
This PR focuses on updating the annotations in the
boot_setsmodule within the server controller code.Like with the other type annotations PR, this one does not change how BOS actually behaves, because Python ignores type annotations at runtime.