Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion of HTTP Service #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Completion of HTTP Service #8

wants to merge 1 commit into from

Conversation

arcadien
Copy link

@arcadien arcadien commented Oct 2, 2019

No description provided.

@arcadien arcadien changed the title feat: Add new RFC for HTTPService completion Completion of HTTP Service Oct 7, 2019
@jeffdiclemente jeffdiclemente added the FCP final commit period label Nov 1, 2019
saschazelzer
saschazelzer approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@saschazelzer saschazelzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the overview, I will try and push reviewing the WIP branch. The mentioned changes to the core framework will have to be discussed separately in the PR, I think.

Concerning the HTTP Service functionality, I think there are no real concerns and it will be a major addition to the project, opening up new use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschazelzer saschazelzer saschazelzer approved these changes

Assignees
No one assigned
Labels
FCP final commit period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arcadien @saschazelzer @jeffdiclemente